Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589028

Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks

Show all headers | View raw

On Mon, Feb 27, 2017 at 2:21 PM, Ruslan Bilovol
<ruslan.bilovol@gmail.com> wrote:
> Config EXPERIMENTAL has been removed from kernel in 2013
> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
> there is no any reason to do these checks now.
>
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  scripts/checkpatch.pl | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 982c52c..e0a34e6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2746,13 +2746,6 @@ sub process {
>                         #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
>                 }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
> -               if ($realfile =~ /Kconfig/ &&
> -                   $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
> -                       WARN("CONFIG_EXPERIMENTAL",
> -                            "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> -               }
> -
>  # discourage the use of boolean for type definition attributes of Kconfig options
>                 if ($realfile =~ /Kconfig/ &&
>                     $line =~ /^\+\s*\bboolean\b/) {
> @@ -3146,12 +3139,6 @@ sub process {
>                         }
>                 }
>
> -# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
> -               if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
> -                       WARN("CONFIG_EXPERIMENTAL",
> -                            "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
> -               }
> -
>  # check for RCS/CVS revision markers
>                 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
>                         WARN("CVS_KEYWORD",
> --
> 1.9.1
>



-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Ruslan Bilovol <ruslan.bilovol@gmail.com> - 2017-02-27 23:30 +0100
  Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Kees Cook <keescook@chromium.org> - 2017-02-28 00:00 +0100
  Re: [PATCH RESEND] checkpatch: remove obsolete CONFIG_EXPERIMENTAL  checks Joe Perches <joe@perches.com> - 2017-02-28 00:50 +0100

csiph-web