Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1587901 > unrolled thread
| Started by | Radim Krčmář <rkrcmar@redhat.com> |
|---|---|
| First post | 2017-02-24 21:00 +0100 |
| Last post | 2017-02-28 13:00 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Radim Krčmář <rkrcmar@redhat.com> - 2017-02-24 21:00 +0100
Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Andrew Jones <drjones@redhat.com> - 2017-02-27 10:20 +0100
Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear David Hildenbrand <david@redhat.com> - 2017-02-27 11:10 +0100
Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear James Hogan <james.hogan@imgtec.com> - 2017-02-28 13:00 +0100
| From | Radim Krčmář <rkrcmar@redhat.com> |
|---|---|
| Date | 2017-02-24 21:00 +0100 |
| Subject | [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear |
| Message-ID | <teuc2-4Ze-23@gated-at.bofh.it> |
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
arch/mips/kvm/emulate.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
index 552ae2b5e911..70614ca41744 100644
--- a/arch/mips/kvm/emulate.c
+++ b/arch/mips/kvm/emulate.c
@@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
* check if any I/O interrupts are pending.
*/
if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
- __kvm_request_clear(KVM_REQ_UNHALT, vcpu);
vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
}
}
--
2.11.1
[toc] | [next] | [standalone]
| From | Andrew Jones <drjones@redhat.com> |
|---|---|
| Date | 2017-02-27 10:20 +0100 |
| Message-ID | <tfpDj-3t3-5@gated-at.bofh.it> |
| In reply to | #1587901 |
On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote:
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> arch/mips/kvm/emulate.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> index 552ae2b5e911..70614ca41744 100644
> --- a/arch/mips/kvm/emulate.c
> +++ b/arch/mips/kvm/emulate.c
> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
> * check if any I/O interrupts are pending.
> */
> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu);
> vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
> }
should remove the {} too.
> }
> --
> 2.11.1
>
[toc] | [prev] | [next] | [standalone]
| From | David Hildenbrand <david@redhat.com> |
|---|---|
| Date | 2017-02-27 11:10 +0100 |
| Message-ID | <tfqpI-45z-27@gated-at.bofh.it> |
| In reply to | #1588560 |
Am 27.02.2017 um 09:45 schrieb Andrew Jones:
> On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote:
>> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
>> ---
>> arch/mips/kvm/emulate.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
>> index 552ae2b5e911..70614ca41744 100644
>> --- a/arch/mips/kvm/emulate.c
>> +++ b/arch/mips/kvm/emulate.c
>> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
>> * check if any I/O interrupts are pending.
>> */
>> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
>> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu);
>> vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
>> }
>
> should remove the {} too.
>
With that,
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David
[toc] | [prev] | [next] | [standalone]
| From | James Hogan <james.hogan@imgtec.com> |
|---|---|
| Date | 2017-02-28 13:00 +0100 |
| Message-ID | <tfOBI-3VC-19@gated-at.bofh.it> |
| In reply to | #1588576 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote:
> Am 27.02.2017 um 09:45 schrieb Andrew Jones:
> > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote:
> >> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> >> ---
> >> arch/mips/kvm/emulate.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> >> index 552ae2b5e911..70614ca41744 100644
> >> --- a/arch/mips/kvm/emulate.c
> >> +++ b/arch/mips/kvm/emulate.c
> >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
> >> * check if any I/O interrupts are pending.
> >> */
> >> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
> >> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu);
> >> vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
> >> }
> >
> > should remove the {} too.
> >
>
> With that,
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
and with that:
Acked-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web