Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear

From	James Hogan <james.hogan@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear
Date	2017-02-28 13:00 +0100
Message-ID	<tfOBI-3VC-19@gated-at.bofh.it> (permalink)
References	<teuc1-4Ze-5@gated-at.bofh.it> <teuc2-4Ze-23@gated-at.bofh.it> <tfpDj-3t3-5@gated-at.bofh.it> <tfqpI-45z-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote:
> Am 27.02.2017 um 09:45 schrieb Andrew Jones:
> > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote:
> >> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> >> ---
> >>  arch/mips/kvm/emulate.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
> >> index 552ae2b5e911..70614ca41744 100644
> >> --- a/arch/mips/kvm/emulate.c
> >> +++ b/arch/mips/kvm/emulate.c
> >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu)
> >>  		 * check if any I/O interrupts are pending.
> >>  		 */
> >>  		if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) {
> >> -			__kvm_request_clear(KVM_REQ_UNHALT, vcpu);
> >>  			vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN;
> >>  		}
> > 
> > should remove the {} too.
> > 
> 
> With that,
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

and with that:

Acked-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Radim Krčmář <rkrcmar@redhat.com> - 2017-02-24 21:00 +0100
  Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Andrew Jones <drjones@redhat.com> - 2017-02-27 10:20 +0100
    Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear David Hildenbrand <david@redhat.com> - 2017-02-27 11:10 +0100
      Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear James Hogan <james.hogan@imgtec.com> - 2017-02-28 13:00 +0100

csiph-web