Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1587762 > unrolled thread
| Started by | Manoj Sawai <mas@iitkgp.ac.in> |
|---|---|
| First post | 2017-02-24 17:20 +0100 |
| Last post | 2017-02-24 18:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning Manoj Sawai <mas@iitkgp.ac.in> - 2017-02-24 17:20 +0100
[PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue Manoj Sawai <mas@iitkgp.ac.in> - 2017-02-24 17:20 +0100
Re: [PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:50 +0100
| From | Manoj Sawai <mas@iitkgp.ac.in> |
|---|---|
| Date | 2017-02-24 17:20 +0100 |
| Subject | [PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning |
| Message-ID | <teqL8-2Ds-25@gated-at.bofh.it> |
Fixed a checkpatch.pl about coding style in comments. '*' missing on subsequent lines. Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> --- drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h index 36e3ef8..cddbe06 100644 --- a/drivers/staging/bcm2835-audio/bcm2835.h +++ b/drivers/staging/bcm2835-audio/bcm2835.h @@ -27,8 +27,8 @@ #include <linux/workqueue.h> /* -#define AUDIO_DEBUG_ENABLE -#define AUDIO_VERBOSE_DEBUG_ENABLE + *#define AUDIO_DEBUG_ENABLE + *#define AUDIO_VERBOSE_DEBUG_ENABLE */ /* Debug macros */ -- 2.7.4
[toc] | [next] | [standalone]
| From | Manoj Sawai <mas@iitkgp.ac.in> |
|---|---|
| Date | 2017-02-24 17:20 +0100 |
| Subject | [PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue |
| Message-ID | <teqL9-2Ds-45@gated-at.bofh.it> |
| In reply to | #1587762 |
fixed the following checkpatch.pl warning:
"drivers/staging/bcm2835-audio/bcm2835-pcm.c:320: WARNING: braces {} are
not necessary for single statement blocks"
Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in>
---
drivers/staging/bcm2835-audio/bcm2835-pcm.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
index 16127e0..b03022d 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
@@ -308,7 +308,8 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream *substream)
/* notify the vchiq that it should enter spdif passthrough mode by
* setting channels=0 (see
- * https://github.com/raspberrypi/linux/issues/528) */
+ * https://github.com/raspberrypi/linux/issues/528)
+ */
if (chip->spdif_status & IEC958_AES0_NONAUDIO)
channels = 0;
else
@@ -317,9 +318,9 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream *substream)
err = bcm2835_audio_set_params(alsa_stream, channels,
alsa_stream->params_rate,
alsa_stream->pcm_format_width);
- if (err < 0) {
+
+ if (err < 0)
audio_error(" error setting hw params\n");
- }
bcm2835_audio_setup(alsa_stream);
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-24 18:50 +0100 |
| Subject | Re: [PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning |
| Message-ID | <tesad-3vj-15@gated-at.bofh.it> |
| In reply to | #1587762 |
On Fri, Feb 24, 2017 at 08:55:14PM +0530, Manoj Sawai wrote: > Fixed a checkpatch.pl about coding style in comments. > '*' missing on subsequent lines. > > Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in> > --- > drivers/staging/bcm2835-audio/bcm2835.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This patch series does not apply to my staging-testing branch due to other people sending in some of these already. Please rebase and resend. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web