Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1587767

[PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue

From Manoj Sawai <mas@iitkgp.ac.in>
Newsgroups linux.kernel
Subject [PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue
Date 2017-02-24 17:20 +0100
Message-ID <teqL9-2Ds-45@gated-at.bofh.it> (permalink)
References <teqL8-2Ds-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


fixed the following checkpatch.pl warning:

"drivers/staging/bcm2835-audio/bcm2835-pcm.c:320: WARNING: braces {} are
not necessary for single statement blocks"

Signed-off-by: Manoj Sawai <mas@iitkgp.ac.in>
---
 drivers/staging/bcm2835-audio/bcm2835-pcm.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
index 16127e0..b03022d 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-pcm.c
@@ -308,7 +308,8 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream *substream)
 
 	/* notify the vchiq that it should enter spdif passthrough mode by
 	 * setting channels=0 (see
-	 * https://github.com/raspberrypi/linux/issues/528) */
+	 * https://github.com/raspberrypi/linux/issues/528)
+	 */
 	if (chip->spdif_status & IEC958_AES0_NONAUDIO)
 		channels = 0;
 	else
@@ -317,9 +318,9 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream *substream)
 	err = bcm2835_audio_set_params(alsa_stream, channels,
 		alsa_stream->params_rate,
 		alsa_stream->pcm_format_width);
-	if (err < 0) {
+
+	if (err < 0)
 		audio_error(" error setting hw params\n");
-	}
 
 	bcm2835_audio_setup(alsa_stream);
 
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch warning Manoj Sawai <mas@iitkgp.ac.in> - 2017-02-24 17:20 +0100
  [PATCH 3/4] Staging: bcm2835-audio: bcm2835-pcm.c: brace coding style issue Manoj Sawai <mas@iitkgp.ac.in> - 2017-02-24 17:20 +0100
  Re: [PATCH 1/4] Staging: bcm2835-audio: bcm2835.h: fixed checkpatch  warning Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:50 +0100

csiph-web