Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586872 > unrolled thread
| Started by | Man Choy <manchoyy@gmail.com> |
|---|---|
| First post | 2017-02-23 14:20 +0100 |
| Last post | 2017-02-23 15:30 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: speakup: synth: Fix checkpatch warning Man Choy <manchoyy@gmail.com> - 2017-02-23 14:20 +0100
Re: [PATCH] staging: speakup: synth: Fix checkpatch warning Joe Perches <joe@perches.com> - 2017-02-23 14:40 +0100
Re: [PATCH] staging: speakup: synth: Fix checkpatch warning Man Choy <manchoyy@gmail.com> - 2017-02-23 15:30 +0100
| From | Man Choy <manchoyy@gmail.com> |
|---|---|
| Date | 2017-02-23 14:20 +0100 |
| Subject | [PATCH] staging: speakup: synth: Fix checkpatch warning |
| Message-ID | <te1tn-1Iv-9@gated-at.bofh.it> |
Signed-off-by: Man Choy <manchoyy@gmail.com>
---
drivers/staging/speakup/synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index a61c02b..1cd38e7 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
if (!spk_quiet_boot)
synth_printf("%s found\n", synth->long_name);
if (synth->attributes.name && sysfs_create_group(speakup_kobj,
- &synth->attributes) < 0)
+ &synth->attributes) < 0)
return -ENOMEM;
synth_flags = synth->flags;
wake_up_interruptible_all(&speakup_event);
--
2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-23 14:40 +0100 |
| Message-ID | <te1MK-1Qh-17@gated-at.bofh.it> |
| In reply to | #1586872 |
On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
[]
> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
[]
> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
> if (!spk_quiet_boot)
> synth_printf("%s found\n", synth->long_name);
> if (synth->attributes.name && sysfs_create_group(speakup_kobj,
> - &synth->attributes) < 0)
> + &synth->attributes) < 0)
Better would be
if (synth->attributes.name &&
sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
[toc] | [prev] | [next] | [standalone]
| From | Man Choy <manchoyy@gmail.com> |
|---|---|
| Date | 2017-02-23 15:30 +0100 |
| Message-ID | <te2z7-2s9-7@gated-at.bofh.it> |
| In reply to | #1586887 |
On Thu, Feb 23, 2017 at 9:34 PM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
> []
>> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> []
>> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
>> if (!spk_quiet_boot)
>> synth_printf("%s found\n", synth->long_name);
>> if (synth->attributes.name && sysfs_create_group(speakup_kobj,
>> - &synth->attributes) < 0)
>> + &synth->attributes) < 0)
>
> Better would be
>
> if (synth->attributes.name &&
> sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
>
Thanks for pointing out. Fixed and sent off PATCH v2.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web