Re: [PATCH] staging: speakup: synth: Fix checkpatch warning

From	Man Choy <manchoyy@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: speakup: synth: Fix checkpatch warning
Date	2017-02-23 15:30 +0100
Message-ID	<te2z7-2s9-7@gated-at.bofh.it> (permalink)
References	<te1tn-1Iv-9@gated-at.bofh.it> <te1MK-1Qh-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 23, 2017 at 9:34 PM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2017-02-23 at 21:15 +0800, Man Choy wrote:
> []
>> diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
> []
>> @@ -407,7 +407,7 @@ static int do_synth_init(struct spk_synth *in_synth)
>>       if (!spk_quiet_boot)
>>               synth_printf("%s found\n", synth->long_name);
>>       if (synth->attributes.name && sysfs_create_group(speakup_kobj,
>> -                                                      &synth->attributes) < 0)
>> +             &synth->attributes) < 0)
>
> Better would be
>
>         if (synth->attributes.name &&
>             sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
>

Thanks for pointing out. Fixed and sent off PATCH v2.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: speakup: synth: Fix checkpatch warning Man Choy <manchoyy@gmail.com> - 2017-02-23 14:20 +0100
  Re: [PATCH] staging: speakup: synth: Fix checkpatch warning Joe Perches <joe@perches.com> - 2017-02-23 14:40 +0100
    Re: [PATCH] staging: speakup: synth: Fix checkpatch warning Man Choy <manchoyy@gmail.com> - 2017-02-23 15:30 +0100

csiph-web