Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586706 > unrolled thread
| Started by | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| First post | 2017-02-23 09:00 +0100 |
| Last post | 2017-02-23 10:30 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCHv7 2/8] printk: rename nmi.c and exported api Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-23 09:00 +0100
Re: [PATCHv7 2/8] printk: rename nmi.c and exported api Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-23 09:20 +0100
Re: [PATCHv7 2/8] printk: rename nmi.c and exported api Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-23 10:30 +0100
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2017-02-23 09:00 +0100 |
| Subject | Re: [PATCHv7 2/8] printk: rename nmi.c and exported api |
| Message-ID | <tdWtH-6D3-15@gated-at.bofh.it> |
Hi Sergey,
On Tue, Dec 27, 2016 at 3:16 PM, Sergey Senozhatsky
<sergey.senozhatsky@gmail.com> wrote:
> A preparation patch for printk_safe work. No functional change.
> - rename nmi.c to print_safe.c
> - add `printk_safe' prefix to some (which used both by printk-safe
> and printk-nmi) of the exported functions.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -875,17 +875,19 @@ config LOG_CPU_MAX_BUF_SHIFT
> 13 => 8 KB for each CPU
> 12 => 4 KB for each CPU
>
> -config NMI_LOG_BUF_SHIFT
> - int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)"
> +config PRINTK_SAFE_LOG_BUF_SHIFT
> + int "Temporary per-CPU printk log buffer size (12 => 4KB, 13 => 8KB)"
> range 10 21
> default 13
> - depends on PRINTK_NMI
> + depends on PRINTK
Was this dependency change intentional?
My platform doesn't have PRINTK_NMI.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [next] | [standalone]
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Date | 2017-02-23 09:20 +0100 |
| Message-ID | <tdWN4-731-31@gated-at.bofh.it> |
| In reply to | #1586706 |
Hello Geert, On (02/23/17 08:50), Geert Uytterhoeven wrote: > Hi Sergey, [..] > > -config NMI_LOG_BUF_SHIFT > > - int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)" > > +config PRINTK_SAFE_LOG_BUF_SHIFT > > + int "Temporary per-CPU printk log buffer size (12 => 4KB, 13 => 8KB)" > > range 10 21 > > default 13 > > - depends on PRINTK_NMI > > + depends on PRINTK > > Was this dependency change intentional? > My platform doesn't have PRINTK_NMI. yes. printk-safe uses the same mechanism as printk-nmi (per-CPU buffers, etc.) and does not depend on HAVE_NMI/PRINTK_NMI, but depends on PRINTK. NMI related part of printk-safe (printk-nmi per-CPU buffers, etc.) is not compiled for !HAVE_NMI systems (since PRINTK_NMI is unset there). -ss
[toc] | [prev] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2017-02-23 10:30 +0100 |
| Message-ID | <tdXSO-7Pd-27@gated-at.bofh.it> |
| In reply to | #1586723 |
Hi Sergey,
On Thu, Feb 23, 2017 at 9:02 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> On (02/23/17 08:50), Geert Uytterhoeven wrote:
>> > -config NMI_LOG_BUF_SHIFT
>> > - int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)"
>> > +config PRINTK_SAFE_LOG_BUF_SHIFT
>> > + int "Temporary per-CPU printk log buffer size (12 => 4KB, 13 => 8KB)"
>> > range 10 21
>> > default 13
>> > - depends on PRINTK_NMI
>> > + depends on PRINTK
>>
>> Was this dependency change intentional?
>> My platform doesn't have PRINTK_NMI.
>
> yes. printk-safe uses the same mechanism as printk-nmi (per-CPU buffers, etc.)
> and does not depend on HAVE_NMI/PRINTK_NMI, but depends on PRINTK.
>
> NMI related part of printk-safe (printk-nmi per-CPU buffers, etc.) is not
> compiled for !HAVE_NMI systems (since PRINTK_NMI is unset there).
OK, thanks for the clarification!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web