Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1586723

Re: [PATCHv7 2/8] printk: rename nmi.c and exported api

From Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCHv7 2/8] printk: rename nmi.c and exported api
Date 2017-02-23 09:20 +0100
Message-ID <tdWN4-731-31@gated-at.bofh.it> (permalink)
References <sT0LE-36Q-9@gated-at.bofh.it> <sT0LE-36Q-15@gated-at.bofh.it> <tdWtH-6D3-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Geert,

On (02/23/17 08:50), Geert Uytterhoeven wrote:
> Hi Sergey,
[..]
> > -config NMI_LOG_BUF_SHIFT
> > -       int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)"
> > +config PRINTK_SAFE_LOG_BUF_SHIFT
> > +       int "Temporary per-CPU printk log buffer size (12 => 4KB, 13 => 8KB)"
> >         range 10 21
> >         default 13
> > -       depends on PRINTK_NMI
> > +       depends on PRINTK
> 
> Was this dependency change intentional?
> My platform doesn't have PRINTK_NMI.

yes. printk-safe uses the same mechanism as printk-nmi (per-CPU buffers, etc.)
and does not depend on HAVE_NMI/PRINTK_NMI, but depends on PRINTK.

NMI related part of printk-safe (printk-nmi per-CPU buffers, etc.) is not
compiled for !HAVE_NMI systems (since PRINTK_NMI is unset there).

	-ss

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCHv7 2/8] printk: rename nmi.c and exported api Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-23 09:00 +0100
  Re: [PATCHv7 2/8] printk: rename nmi.c and exported api Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-02-23 09:20 +0100
    Re: [PATCHv7 2/8] printk: rename nmi.c and exported api Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-23 10:30 +0100

csiph-web