Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586479 > unrolled thread
| Started by | "Tobin C. Harding" <me@tobin.cc> |
|---|---|
| First post | 2017-02-22 22:10 +0100 |
| Last post | 2017-02-22 22:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] ncpfs: Remove cast from memory allocation "Tobin C. Harding" <me@tobin.cc> - 2017-02-22 22:10 +0100
Re: [PATCH v2] ncpfs: Remove cast from memory allocation Julia Lawall <julia.lawall@lip6.fr> - 2017-02-22 22:20 +0100
| From | "Tobin C. Harding" <me@tobin.cc> |
|---|---|
| Date | 2017-02-22 22:10 +0100 |
| Subject | [PATCH v2] ncpfs: Remove cast from memory allocation |
| Message-ID | <tdMkF-7Gh-9@gated-at.bofh.it> |
Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct ncp_inode_info *) is useless.
Remove unnecessary cast.
Changes since v1:
- Fix up typo
Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
Kernel built successfully with patch applied.
fs/ncpfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c
index 7eb89c2..7a9ed33 100644
--- a/fs/ncpfs/inode.c
+++ b/fs/ncpfs/inode.c
@@ -52,7 +52,7 @@ static struct kmem_cache * ncp_inode_cachep;
static struct inode *ncp_alloc_inode(struct super_block *sb)
{
struct ncp_inode_info *ei;
- ei = (struct ncp_inode_info *)kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
+ ei = kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
if (!ei)
return NULL;
return &ei->vfs_inode;
--
2.7.4
[toc] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-02-22 22:20 +0100 |
| Message-ID | <tdMun-7Lo-37@gated-at.bofh.it> |
| In reply to | #1586479 |
On Thu, 23 Feb 2017, Tobin C. Harding wrote:
> Coccinelle emits WARNING: casting value returned by memory allocation
> function to (struct ncp_inode_info *) is useless.
>
> Remove unnecessary cast.
>
> Changes since v1:
> - Fix up typo
Changes since v1 goes below the ---. When this ends up in the git
history, no one will care about the changes since v1, because v1 won't be
part of the history.
julia
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
> ---
>
> Kernel built successfully with patch applied.
>
> fs/ncpfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c
> index 7eb89c2..7a9ed33 100644
> --- a/fs/ncpfs/inode.c
> +++ b/fs/ncpfs/inode.c
> @@ -52,7 +52,7 @@ static struct kmem_cache * ncp_inode_cachep;
> static struct inode *ncp_alloc_inode(struct super_block *sb)
> {
> struct ncp_inode_info *ei;
> - ei = (struct ncp_inode_info *)kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
> + ei = kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
> if (!ei)
> return NULL;
> return &ei->vfs_inode;
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web