Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586491

Re: [PATCH v2] ncpfs: Remove cast from memory allocation

Show all headers | View raw

On Thu, 23 Feb 2017, Tobin C. Harding wrote:

> Coccinelle emits WARNING: casting value returned by memory allocation
> function to (struct ncp_inode_info *) is useless.
>
> Remove unnecessary cast.
>
> Changes since v1:
>  - Fix up typo

Changes since v1 goes below the ---.  When this ends up in the git
history, no one will care about the changes since v1, because v1 won't be
part of the history.

julia

>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
> ---
>
> Kernel built successfully with patch applied.
>
>  fs/ncpfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c
> index 7eb89c2..7a9ed33 100644
> --- a/fs/ncpfs/inode.c
> +++ b/fs/ncpfs/inode.c
> @@ -52,7 +52,7 @@ static struct kmem_cache * ncp_inode_cachep;
>  static struct inode *ncp_alloc_inode(struct super_block *sb)
>  {
>  	struct ncp_inode_info *ei;
> -	ei = (struct ncp_inode_info *)kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
> +	ei = kmem_cache_alloc(ncp_inode_cachep, GFP_KERNEL);
>  	if (!ei)
>  		return NULL;
>  	return &ei->vfs_inode;
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] ncpfs: Remove cast from memory allocation "Tobin C. Harding" <me@tobin.cc> - 2017-02-22 22:10 +0100
  Re: [PATCH v2] ncpfs: Remove cast from memory allocation Julia Lawall <julia.lawall@lip6.fr> - 2017-02-22 22:20 +0100

csiph-web