Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583947 > unrolled thread
| Started by | simran singhal <singhalsimran0@gmail.com> |
|---|---|
| First post | 2017-02-18 19:40 +0100 |
| Last post | 2017-02-18 20:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses simran singhal <singhalsimran0@gmail.com> - 2017-02-18 19:40 +0100
Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses Julia Lawall <julia.lawall@lip6.fr> - 2017-02-18 20:20 +0100
Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses Joe Perches <joe@perches.com> - 2017-02-18 20:30 +0100
Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses Julia Lawall <julia.lawall@lip6.fr> - 2017-02-18 20:50 +0100
| From | simran singhal <singhalsimran0@gmail.com> |
|---|---|
| Date | 2017-02-18 19:40 +0100 |
| Subject | [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses |
| Message-ID | <tci5k-5iU-7@gated-at.bofh.it> |
Extra parentheses were causing checkpatch issues
and were removed.
Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index cded0f4..1391c91 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
- pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
+ pCapELE = (struct ht_capab_ele *)&posHTCap[4];
*len = 30 + 2;
} else {
pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
- memset((void *)(&(pHTInfo->SelfHTCap)), 0,
+ memset((void *)(&pHTInfo->SelfHTCap), 0,
sizeof(pHTInfo->SelfHTCap));
- memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
+ memset((void *)(&pHTInfo->SelfHTInfo), 0,
sizeof(pHTInfo->SelfHTInfo));
- memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
+ memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
sizeof(pHTInfo->PeerHTCapBuf));
- memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
+ memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
sizeof(pHTInfo->PeerHTInfoBuf));
pHTInfo->bSwBwInProgress = false;
@@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
pHTInfo->IOTRaFunc = 0;
{
- u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
+ u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
RegHTSuppRateSets[0] = 0xFF;
RegHTSuppRateSets[1] = 0xFF;
--
2.7.4
[toc] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-02-18 20:20 +0100 |
| Subject | Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses |
| Message-ID | <tciI2-5Nq-5@gated-at.bofh.it> |
| In reply to | #1583947 |
On Sun, 19 Feb 2017, simran singhal wrote:
> Extra parentheses were causing checkpatch issues
> and were removed.
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index cded0f4..1391c91 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
> u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
>
> memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
> - pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
> + pCapELE = (struct ht_capab_ele *)&posHTCap[4];
> *len = 30 + 2;
> } else {
> pCapELE = (struct ht_capab_ele *)posHTCap;
> @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
>
> - memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> + memset((void *)(&pHTInfo->SelfHTCap), 0,
You don't need the parens around the argument of the cast either.
julia
> sizeof(pHTInfo->SelfHTCap));
> - memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
> + memset((void *)(&pHTInfo->SelfHTInfo), 0,
> sizeof(pHTInfo->SelfHTInfo));
> - memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
> + memset((void *)(&pHTInfo->PeerHTCapBuf), 0,
> sizeof(pHTInfo->PeerHTCapBuf));
> - memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
> + memset((void *)(&pHTInfo->PeerHTInfoBuf), 0,
> sizeof(pHTInfo->PeerHTInfoBuf));
>
> pHTInfo->bSwBwInProgress = false;
> @@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> pHTInfo->IOTRaFunc = 0;
>
> {
> - u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
> + u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
>
> RegHTSuppRateSets[0] = 0xFF;
> RegHTSuppRateSets[1] = 0xFF;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218183648.GA2680%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-18 20:30 +0100 |
| Subject | Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses |
| Message-ID | <tciRH-5QK-1@gated-at.bofh.it> |
| In reply to | #1583955 |
On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > On Sun, 19 Feb 2017, simran singhal wrote: > > Extra parentheses were causing checkpatch issues > > and were removed. [] > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c [] > > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) > > pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; > > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; > > > > - memset((void *)(&(pHTInfo->SelfHTCap)), 0, > > + memset((void *)(&pHTInfo->SelfHTCap), 0, > > You don't need the parens around the argument of the cast either. Nor need the cast at all. memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap)); etc...
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-02-18 20:50 +0100 |
| Subject | Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses |
| Message-ID | <tcjb3-5X2-9@gated-at.bofh.it> |
| In reply to | #1583958 |
On Sat, 18 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > > On Sun, 19 Feb 2017, simran singhal wrote: > > > Extra parentheses were causing checkpatch issues > > > and were removed. > [] > > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c > [] > > > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) > > > pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; > > > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; > > > > > > - memset((void *)(&(pHTInfo->SelfHTCap)), 0, > > > + memset((void *)(&pHTInfo->SelfHTCap), 0, > > > > You don't need the parens around the argument of the cast either. > > Nor need the cast at all. > > memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap)); > > etc... Indeed. Thanks! julia
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web