Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1583958

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses
Date 2017-02-18 20:30 +0100
Message-ID <tciRH-5QK-1@gated-at.bofh.it> (permalink)
References <tci5k-5iU-7@gated-at.bofh.it> <tciI2-5Nq-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote:
> On Sun, 19 Feb 2017, simran singhal wrote:
> > Extra parentheses were causing checkpatch issues
> > and were removed.
[]
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
[]
> > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> >  	pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> >  	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> > 
> > -	memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> > +	memset((void *)(&pHTInfo->SelfHTCap), 0,
> 
> You don't need the parens around the argument of the cast either.

Nor need the cast at all.

	memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));

etc...

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses simran singhal <singhalsimran0@gmail.com> - 2017-02-18 19:40 +0100
  Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed  unnecessary parentheses Julia Lawall <julia.lawall@lip6.fr> - 2017-02-18 20:20 +0100
    Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed  unnecessary parentheses Joe Perches <joe@perches.com> - 2017-02-18 20:30 +0100
      Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed  unnecessary parentheses Julia Lawall <julia.lawall@lip6.fr> - 2017-02-18 20:50 +0100

csiph-web