Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583817 > unrolled thread

Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at runtime suspend/resume

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at runtime suspend/resume Kevin Hilman <khilman@baylibre.com> - 2017-02-18 01:00 +0100
    Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at  runtime suspend/resume Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-20 10:30 +0100

#1583817 — Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at runtime suspend/resume

Viresh Kumar <viresh.kumar@linaro.org> writes:

> With runtime PM, the devices get suspended while the system is up and
> running in order to save power. At such times, it is important to
> re-evaluate the required performance state of the domain, in order to
> choose a lower state if possible.
>
> This patch updates the genpd suspend/resume callbacks to do that.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Doesn't this assume that a device in the domain would need to change
performance state while runtime suspended.  How would that happen?

Rather than adding this here, I would think that drivers would instead
remove any QoS requests before going into runtime suspend, which would
trigger an update before runtime suspending.

Kevin

[toc] | [next] | [standalone]

#1584434 — Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at runtime suspend/resume

On 17-02-17, 15:58, Kevin Hilman wrote:
> Viresh Kumar <viresh.kumar@linaro.org> writes:
> 
> > With runtime PM, the devices get suspended while the system is up and
> > running in order to save power. At such times, it is important to
> > re-evaluate the required performance state of the domain, in order to
> > choose a lower state if possible.
> >
> > This patch updates the genpd suspend/resume callbacks to do that.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Doesn't this assume that a device in the domain would need to change
> performance state while runtime suspended.  How would that happen?
> 
> Rather than adding this here, I would think that drivers would instead
> remove any QoS requests before going into runtime suspend, which would
> trigger an update before runtime suspending.

Okay, lets leave it for the drivers, at least for the time being. I
will drop this patch.

-- 
viresh

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web