Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at runtime suspend/resume

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at runtime suspend/resume
Date	2017-02-20 10:30 +0100
Message-ID	<tcSs9-2P5-15@gated-at.bofh.it> (permalink)
References	<t8NU6-LX-15@gated-at.bofh.it> <t8NU6-LX-15@gated-at.bofh.it> <t8Odr-187-7@gated-at.bofh.it> <tc0Br-2zX-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 17-02-17, 15:58, Kevin Hilman wrote:
> Viresh Kumar <viresh.kumar@linaro.org> writes:
> 
> > With runtime PM, the devices get suspended while the system is up and
> > running in order to save power. At such times, it is important to
> > re-evaluate the required performance state of the domain, in order to
> > choose a lower state if possible.
> >
> > This patch updates the genpd suspend/resume callbacks to do that.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> Doesn't this assume that a device in the domain would need to change
> performance state while runtime suspended.  How would that happen?
> 
> Rather than adding this here, I would think that drivers would instead
> remove any QoS requests before going into runtime suspend, which would
> trigger an update before runtime suspending.

Okay, lets leave it for the drivers, at least for the time being. I
will drop this patch.

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at runtime suspend/resume Kevin Hilman <khilman@baylibre.com> - 2017-02-18 01:00 +0100
  Re: [PATCH V2 5/6] PM / domain: Save/restore performance state at  runtime suspend/resume Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-20 10:30 +0100

csiph-web