Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1582439 > unrolled thread
| Started by | Oliver Neukum <oneukum@suse.com> |
|---|---|
| First post | 2017-02-16 11:30 +0100 |
| Last post | 2017-02-16 22:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code Oliver Neukum <oneukum@suse.com> - 2017-02-16 11:30 +0100
Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code Greg KH <gregkh@linuxfoundation.org> - 2017-02-16 17:40 +0100
Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-02-16 22:10 +0100
| From | Oliver Neukum <oneukum@suse.com> |
|---|---|
| Date | 2017-02-16 11:30 +0100 |
| Subject | Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code |
| Message-ID | <tbru1-4Oj-1@gated-at.bofh.it> |
Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > The condition modex % 16 cannot be true when modex value is equal to > 640 > The condition du & 0xff cannot be true when du value is equal to > 0x1400 > Sorry for speaking up so late, but this is not a good idea. We lose the knowledge how to do this correctly, if we want to change the resolution. Regards Oliver
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-16 17:40 +0100 |
| Message-ID | <tbxg6-uI-11@gated-at.bofh.it> |
| In reply to | #1582439 |
On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: > Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: > > The condition modex % 16 cannot be true when modex value is equal to > > 640 > > The condition du & 0xff cannot be true when du value is equal to > > 0x1400 > > > > Sorry for speaking up so late, but this is not a good idea. > We lose the knowledge how to do this correctly, if we want > to change the resolution. Given the age of this driver, I doubt that will ever happen :) thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Felipe Balbi <felipe.balbi@linux.intel.com> |
|---|---|
| Date | 2017-02-16 22:10 +0100 |
| Message-ID | <tbBtn-3uQ-11@gated-at.bofh.it> |
| In reply to | #1582694 |
Hi, Greg KH <gregkh@linuxfoundation.org> writes: > On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: >> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: >> > The condition modex % 16 cannot be true when modex value is equal to >> > 640 >> > The condition du & 0xff cannot be true when du value is equal to >> > 0x1400 >> > >> >> Sorry for speaking up so late, but this is not a good idea. >> We lose the knowledge how to do this correctly, if we want >> to change the resolution. > > Given the age of this driver, I doubt that will ever happen :) besides, the "knowledge" will always be in git history. -- balbi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web