Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code

From	Felipe Balbi <felipe.balbi@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code
Date	2017-02-16 22:10 +0100
Message-ID	<tbBtn-3uQ-11@gated-at.bofh.it> (permalink)
References	<t8smB-3Vl-9@gated-at.bofh.it> <tbru1-4Oj-1@gated-at.bofh.it> <tbxg6-uI-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

Greg KH <gregkh@linuxfoundation.org> writes:
> On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote:
>> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva:
>> > The condition modex % 16 cannot be true when modex value is equal to
>> > 640
>> > The condition du & 0xff cannot be true when du value is equal to
>> > 0x1400
>> > 
>> 
>> Sorry for speaking up so late, but this is not a good idea.
>> We lose the knowledge how to do this correctly, if we want
>> to change the resolution.
>
> Given the age of this driver, I doubt that will ever happen :)

besides, the "knowledge" will always be in git history.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code Oliver Neukum <oneukum@suse.com> - 2017-02-16 11:30 +0100
  Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code Greg KH <gregkh@linuxfoundation.org> - 2017-02-16 17:40 +0100
    Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-02-16 22:10 +0100

csiph-web