Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583716 > unrolled thread
| Started by | Nathan Howard <adanhawthorn@gmail.com> |
|---|---|
| First post | 2017-02-17 21:20 +0100 |
| Last post | 2017-02-18 01:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue Nathan Howard <adanhawthorn@gmail.com> - 2017-02-17 21:20 +0100
Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue Joe Perches <joe@perches.com> - 2017-02-18 00:10 +0100
Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue Adan Hawthorn <adanhawthorn@gmail.com> - 2017-02-18 01:50 +0100
| From | Nathan Howard <adanhawthorn@gmail.com> |
|---|---|
| Date | 2017-02-17 21:20 +0100 |
| Subject | [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue |
| Message-ID | <tbXay-tp-25@gated-at.bofh.it> |
Fix checkpatch.pl warning of the form "WARNING: Use of volatile is
usually wrong: see Documentation/process/volatile-considered-harmful.rst."
Signed-off-by: Nathan Howard <adanhawthorn@gmail.com>
---
drivers/staging/bcm2835-audio/bcm2835.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h
index 2f9d1c9..08f7ad6 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.h
+++ b/drivers/staging/bcm2835-audio/bcm2835.h
@@ -125,8 +125,8 @@ struct bcm2835_alsa_stream {
struct semaphore buffers_update_sem;
struct semaphore control_sem;
spinlock_t lock;
- volatile unsigned int control;
- volatile unsigned int status;
+ unsigned int control;
+ unsigned int status;
int open;
int running;
--
2.7.4
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-18 00:10 +0100 |
| Subject | Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue |
| Message-ID | <tbZP3-2hr-3@gated-at.bofh.it> |
| In reply to | #1583716 |
On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote:
> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is
> usually wrong: see Documentation/process/volatile-considered-harmful.rst."
Why are you sure the volatile use is not necessary?
> Signed-off-by: Nathan Howard <adanhawthorn@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h
> index 2f9d1c9..08f7ad6 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.h
> +++ b/drivers/staging/bcm2835-audio/bcm2835.h
> @@ -125,8 +125,8 @@ struct bcm2835_alsa_stream {
> struct semaphore buffers_update_sem;
> struct semaphore control_sem;
> spinlock_t lock;
> - volatile unsigned int control;
> - volatile unsigned int status;
> + unsigned int control;
> + unsigned int status;
>
> int open;
> int running;
[toc] | [prev] | [next] | [standalone]
| From | Adan Hawthorn <adanhawthorn@gmail.com> |
|---|---|
| Date | 2017-02-18 01:50 +0100 |
| Subject | Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue |
| Message-ID | <tc1nQ-38a-3@gated-at.bofh.it> |
| In reply to | #1583794 |
Thank you, Joe.
Please remove this patch at this time; it was sent in error.
On Fri, Feb 17, 2017 at 6:04 PM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote:
>> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is
>> usually wrong: see Documentation/process/volatile-considered-harmful.rst."
>
> Why are you sure the volatile use is not necessary?
>
>> Signed-off-by: Nathan Howard <adanhawthorn@gmail.com>
>> ---
>> drivers/staging/bcm2835-audio/bcm2835.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h
>> index 2f9d1c9..08f7ad6 100644
>> --- a/drivers/staging/bcm2835-audio/bcm2835.h
>> +++ b/drivers/staging/bcm2835-audio/bcm2835.h
>> @@ -125,8 +125,8 @@ struct bcm2835_alsa_stream {
>> struct semaphore buffers_update_sem;
>> struct semaphore control_sem;
>> spinlock_t lock;
>> - volatile unsigned int control;
>> - volatile unsigned int status;
>> + unsigned int control;
>> + unsigned int status;
>>
>> int open;
>> int running;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web