Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583794
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue |
| Date | 2017-02-18 00:10 +0100 |
| Message-ID | <tbZP3-2hr-3@gated-at.bofh.it> (permalink) |
| References | <tbXay-tp-21@gated-at.bofh.it> <tbXay-tp-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-02-17 at 15:16 -0500, Nathan Howard wrote:
> Fix checkpatch.pl warning of the form "WARNING: Use of volatile is
> usually wrong: see Documentation/process/volatile-considered-harmful.rst."
Why are you sure the volatile use is not necessary?
> Signed-off-by: Nathan Howard <adanhawthorn@gmail.com>
> ---
> drivers/staging/bcm2835-audio/bcm2835.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.h b/drivers/staging/bcm2835-audio/bcm2835.h
> index 2f9d1c9..08f7ad6 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.h
> +++ b/drivers/staging/bcm2835-audio/bcm2835.h
> @@ -125,8 +125,8 @@ struct bcm2835_alsa_stream {
> struct semaphore buffers_update_sem;
> struct semaphore control_sem;
> spinlock_t lock;
> - volatile unsigned int control;
> - volatile unsigned int status;
> + unsigned int control;
> + unsigned int status;
>
> int open;
> int running;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue Nathan Howard <adanhawthorn@gmail.com> - 2017-02-17 21:20 +0100
Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue Joe Perches <joe@perches.com> - 2017-02-18 00:10 +0100
Re: [PATCH 4/5] staging: bcm2835-audio: bcm2835.h: fix volatile coding style issue Adan Hawthorn <adanhawthorn@gmail.com> - 2017-02-18 01:50 +0100
csiph-web