Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583729 > unrolled thread
| Started by | Ansuel Smith <ansuelsmth@gmail.com> |
|---|---|
| First post | 2017-02-17 21:50 +0100 |
| Last post | 2017-02-19 01:10 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] DTS: Linksys Board: Add default trigger for sata led Ansuel Smith <ansuelsmth@gmail.com> - 2017-02-17 21:50 +0100
Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led Jason Cooper <jason@lakedaemon.net> - 2017-02-18 15:40 +0100
Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led Andreas Färber <afaerber@suse.de> - 2017-02-19 01:10 +0100
| From | Ansuel Smith <ansuelsmth@gmail.com> |
|---|---|
| Date | 2017-02-17 21:50 +0100 |
| Subject | [PATCH] DTS: Linksys Board: Add default trigger for sata led |
| Message-ID | <tbXDA-DC-13@gated-at.bofh.it> |
In others board we have the sata led set to funcion with the sata led trigger by default.
This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
index f3cee91..a1b6e68 100644
--- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
@@ -109,6 +109,7 @@
sata {
label = "caiman:white:sata";
+ linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
index 1110718..a1a75af 100644
--- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
@@ -109,6 +109,7 @@
sata {
label = "cobra:white:sata";
+ linux,default-trigger = "disk-activity";
};
};
};
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 83ac884..dcd73ab 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -156,6 +156,7 @@
esata@4 {
label = "mamba:white:esata";
reg = <0x4>;
+ linux,default-trigger = "disk-activity";
};
usb2@5 {
--
1.9.1
[toc] | [next] | [standalone]
| From | Jason Cooper <jason@lakedaemon.net> |
|---|---|
| Date | 2017-02-18 15:40 +0100 |
| Message-ID | <tcel3-33O-5@gated-at.bofh.it> |
| In reply to | #1583729 |
Hi Ansuel,
On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
> In others board we have the sata led set to funcion with the sata led trigger by default.
> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Please line wrap the commit message. Other than that,
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Acked-by: Jason Cooper <jason@lakedaemon.net>
thx,
Jason.
> ---
> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 +
> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> index f3cee91..a1b6e68 100644
> --- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> +++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
> @@ -109,6 +109,7 @@
>
> sata {
> label = "caiman:white:sata";
> + linux,default-trigger = "disk-activity";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> index 1110718..a1a75af 100644
> --- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> +++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
> @@ -109,6 +109,7 @@
>
> sata {
> label = "cobra:white:sata";
> + linux,default-trigger = "disk-activity";
> };
> };
> };
> diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> index 83ac884..dcd73ab 100644
> --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
> @@ -156,6 +156,7 @@
> esata@4 {
> label = "mamba:white:esata";
> reg = <0x4>;
> + linux,default-trigger = "disk-activity";
> };
>
> usb2@5 {
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2017-02-19 01:10 +0100 |
| Message-ID | <tcneF-gZ-5@gated-at.bofh.it> |
| In reply to | #1583908 |
Hi, Am 18.02.2017 um 15:12 schrieb Jason Cooper: > On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote: >> In others board we have the sata led set to funcion with the sata led trigger by default. >> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger > > Please line wrap the commit message. The subject could also use some love, like mentioning "ARM:" and "armada" and dropping "Board". Compare git log --oneline. Regards, Andreas > Other than that, > >> >> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > Acked-by: Jason Cooper <jason@lakedaemon.net> > > thx, > > Jason. > >> --- >> arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 + >> arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 + >> arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 1 + >> 3 files changed, 3 insertions(+) -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web