Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1584043

Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led

From Andreas Färber <afaerber@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led
Date 2017-02-19 01:10 +0100
Message-ID <tcneF-gZ-5@gated-at.bofh.it> (permalink)
References <tbXDA-DC-13@gated-at.bofh.it> <tcel3-33O-5@gated-at.bofh.it>
Organization SUSE Linux GmbH

Show all headers | View raw


Hi,

Am 18.02.2017 um 15:12 schrieb Jason Cooper:
> On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
>> In others board we have the sata led set to funcion with the sata led trigger by default.
>> This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
> 
> Please line wrap the commit message.

The subject could also use some love, like mentioning "ARM:" and
"armada" and dropping "Board". Compare git log --oneline.

Regards,
Andreas

>  Other than that,
> 
>>
>> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> 
> Acked-by: Jason Cooper <jason@lakedaemon.net>
> 
> thx,
> 
> Jason.
> 
>> ---
>>  arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
>>  arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 1 +
>>  arch/arm/boot/dts/armada-xp-linksys-mamba.dts   | 1 +
>>  3 files changed, 3 insertions(+)

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] DTS: Linksys Board: Add default trigger for sata led Ansuel Smith <ansuelsmth@gmail.com> - 2017-02-17 21:50 +0100
  Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led Jason Cooper <jason@lakedaemon.net> - 2017-02-18 15:40 +0100
    Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led Andreas Färber <afaerber@suse.de> - 2017-02-19 01:10 +0100

csiph-web