Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1575869 > unrolled thread
| Started by | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| First post | 2017-02-07 17:50 +0100 |
| Last post | 2017-02-16 18:50 +0100 |
| Articles | 20 on this page of 21 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH 00/10] ARM: davinci: add vpif display support Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
[PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port Rob Herring <robh@kernel.org> - 2017-02-15 23:10 +0100
Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-02-16 08:40 +0100
Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-16 17:10 +0100
Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port Rob Herring <robh@kernel.org> - 2017-02-15 23:10 +0100
[PATCH 04/10] ARM: dts: da850-evm: add the output port to the vpif node Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
[PATCH 06/10] ARM: davinci_all_defconfig: enable VPIF display modules Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
[PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors Kevin Hilman <khilman@baylibre.com> - 2017-02-13 19:30 +0100
Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors Kevin Hilman <khilman@baylibre.com> - 2017-02-13 19:40 +0100
Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors Kevin Hilman <khilman@baylibre.com> - 2017-02-13 22:10 +0100
Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors Sekhar Nori <nsekhar@ti.com> - 2017-02-14 07:40 +0100
[PATCH 05/10] ARM: dts: da850: add vpif video display pins Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
[PATCH 01/10] media: dt-bindings: vpif: fix whitespace errors Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
Re: [PATCH 01/10] media: dt-bindings: vpif: fix whitespace errors Rob Herring <robh@kernel.org> - 2017-02-15 23:10 +0100
[PATCH 07/10] ARM: davinci: fix a whitespace error Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-07 17:50 +0100
Re: [PATCH 07/10] ARM: davinci: fix a whitespace error Kevin Hilman <khilman@baylibre.com> - 2017-02-13 19:40 +0100
Re: [PATCH 07/10] ARM: davinci: fix a whitespace error Kevin Hilman <khilman@baylibre.com> - 2017-02-13 22:10 +0100
Re: [PATCH 00/10] ARM: davinci: add vpif display support Sekhar Nori <nsekhar@ti.com> - 2017-02-13 10:30 +0100
Re: [PATCH 00/10] ARM: davinci: add vpif display support Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-16 18:50 +0100
Page 1 of 2 [1] 2 Next page →
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 00/10] ARM: davinci: add vpif display support |
| Message-ID | <t8h7P-5ki-3@gated-at.bofh.it> |
The following series adds support for v4l2 display on da850-evm with a UI board in device tree boot mode. Patches 1/10 - 5/10 deal with the device tree: we fix whitespace errors in dts files and bindings, extend the example and the dts for da850-evm with the output port and address the pinmuxing. Patch 6/10 enables the relevant modules in the defconfig file. Patches 7/10 and 8/10 fix two already existing bugs encountered during development. Patch 9/10 make it possible to use a different i2c adapter in the vpif display driver. The last patch adds the pdata quirks necessary to enable v4l2 display. Tested with a modified version of yavta[1] as gstreamer support for v4l2 seems to be broken and results in picture artifacts. [1] https://github.com/brgl/yavta davinci/vpif-display Bartosz Golaszewski (10): media: dt-bindings: vpif: fix whitespace errors ARM: dts: da850-evm: fix whitespace errors media: dt-bindings: vpif: extend the example with an output port ARM: dts: da850-evm: add the output port to the vpif node ARM: dts: da850: add vpif video display pins ARM: davinci_all_defconfig: enable VPIF display modules ARM: davinci: fix a whitespace error ARM: davinci: fix the DT boot on da850-evm media: vpif: use a configurable i2c_adapter_id for vpif display ARM: davinci: add pdata-quirks for da850-evm vpif display .../devicetree/bindings/media/ti,da850-vpif.txt | 45 ++++++++--- arch/arm/boot/dts/da850-evm.dts | 26 +++--- arch/arm/boot/dts/da850.dtsi | 25 +++++- arch/arm/configs/davinci_all_defconfig | 2 + arch/arm/mach-davinci/board-da850-evm.c | 1 + arch/arm/mach-davinci/pdata-quirks.c | 92 ++++++++++++++++++++-- drivers/media/platform/davinci/vpif_display.c | 2 +- include/media/davinci/vpif_types.h | 1 + 8 files changed, 164 insertions(+), 30 deletions(-) -- 2.9.3
[toc] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port |
| Message-ID | <t8h7Q-5ki-13@gated-at.bofh.it> |
| In reply to | #1575869 |
This makes the example more or less correspond with the da850-evm
hardware setup.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
.../devicetree/bindings/media/ti,da850-vpif.txt | 35 ++++++++++++++++++----
1 file changed, 29 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
index 9c7510b..543f6f3 100644
--- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
+++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
@@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
reg = <0x217000 0x1000>;
interrupts = <92>;
- port {
- vpif_ch0: endpoint@0 {
+ port@0 {
+ vpif_input_ch0: endpoint@0 {
reg = <0>;
bus-width = <8>;
- remote-endpoint = <&composite>;
+ remote-endpoint = <&composite_in>;
};
- vpif_ch1: endpoint@1 {
+ vpif_input_ch1: endpoint@1 {
reg = <1>;
bus-width = <8>;
data-shift = <8>;
};
};
+
+ port@1 {
+ vpif_output_ch0: endpoint@0 {
+ reg = <0>;
+ bus-width = <8>;
+ remote-endpoint = <&composite_out>;
+ };
+ };
};
[ ... ]
@@ -53,13 +61,28 @@ I2C-connected TVP5147 decoder:
status = "okay";
port {
- composite: endpoint {
+ composite_in: endpoint {
hsync-active = <1>;
vsync-active = <1>;
pclk-sample = <0>;
/* VPIF channel 0 (lower 8-bits) */
- remote-endpoint = <&vpif_ch0>;
+ remote-endpoint = <&vpif_input_ch0>;
+ bus-width = <8>;
+ };
+ };
+ };
+
+ adv7343@2a {
+ compatible = "adi,adv7343";
+ reg = <0x2a>;
+
+ port {
+ composite_out: endpoint {
+ adi,dac-enable = <1 1 1>;
+ adi,sd-dac-enable = <1>;
+
+ remote-endpoint = <&vpif_output_ch0>;
bus-width = <8>;
};
};
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-02-15 23:10 +0100 |
| Subject | Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port |
| Message-ID | <tbfVT-5G3-9@gated-at.bofh.it> |
| In reply to | #1575871 |
On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> This makes the example more or less correspond with the da850-evm
> hardware setup.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> .../devicetree/bindings/media/ti,da850-vpif.txt | 35 ++++++++++++++++++----
> 1 file changed, 29 insertions(+), 6 deletions(-)
Spoke too soon...
>
> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> index 9c7510b..543f6f3 100644
> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
> reg = <0x217000 0x1000>;
> interrupts = <92>;
>
> - port {
> - vpif_ch0: endpoint@0 {
> + port@0 {
> + vpif_input_ch0: endpoint@0 {
> reg = <0>;
> bus-width = <8>;
> - remote-endpoint = <&composite>;
> + remote-endpoint = <&composite_in>;
> };
>
> - vpif_ch1: endpoint@1 {
> + vpif_input_ch1: endpoint@1 {
> reg = <1>;
> bus-width = <8>;
> data-shift = <8>;
> };
> };
> +
> + port@1 {
The binding doc says nothing about supporting a 2nd port.
> + vpif_output_ch0: endpoint@0 {
> + reg = <0>;
Don't need reg here.
> + bus-width = <8>;
> + remote-endpoint = <&composite_out>;
> + };
> + };
> };
[toc] | [prev] | [next] | [standalone]
| From | Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
|---|---|
| Date | 2017-02-16 08:40 +0100 |
| Subject | Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port |
| Message-ID | <tboPv-32i-9@gated-at.bofh.it> |
| In reply to | #1581707 |
Hi Rob,
On Wednesday 15 Feb 2017 16:08:22 Rob Herring wrote:
> On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> > This makes the example more or less correspond with the da850-evm
> > hardware setup.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> >
> > .../devicetree/bindings/media/ti,da850-vpif.txt | 35 +++++++++++++----
> > 1 file changed, 29 insertions(+), 6 deletions(-)
>
> Spoke too soon...
>
> > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt index
> > 9c7510b..543f6f3 100644
> > --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> > @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
> > reg = <0x217000 0x1000>;
> > interrupts = <92>;
> >
> > - port {
> > - vpif_ch0: endpoint@0 {
> > + port@0 {
> > + vpif_input_ch0: endpoint@0 {
> > reg = <0>;
> > bus-width = <8>;
> > - remote-endpoint = <&composite>;
> > + remote-endpoint = <&composite_in>;
> > };
> >
> > - vpif_ch1: endpoint@1 {
> > + vpif_input_ch1: endpoint@1 {
> > reg = <1>;
> > bus-width = <8>;
> > data-shift = <8>;
> > };
> > };
> > +
> > + port@1 {
>
> The binding doc says nothing about supporting a 2nd port.
>
> > + vpif_output_ch0: endpoint@0 {
> > + reg = <0>;
>
> Don't need reg here.
And the node should then be named endpoint, not endpoint@0.
> > + bus-width = <8>;
> > + remote-endpoint = <&composite_out>;
> > + };
> > + };
> > };
--
Regards,
Laurent Pinchart
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-16 17:10 +0100 |
| Subject | Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port |
| Message-ID | <tbwN4-fF-27@gated-at.bofh.it> |
| In reply to | #1581707 |
2017-02-15 23:08 GMT+01:00 Rob Herring <robh@kernel.org>:
> On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
>> This makes the example more or less correspond with the da850-evm
>> hardware setup.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>> .../devicetree/bindings/media/ti,da850-vpif.txt | 35 ++++++++++++++++++----
>> 1 file changed, 29 insertions(+), 6 deletions(-)
>
> Spoke too soon...
>
>>
>> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
>> index 9c7510b..543f6f3 100644
>> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
>> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
>> @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
>> reg = <0x217000 0x1000>;
>> interrupts = <92>;
>>
>> - port {
>> - vpif_ch0: endpoint@0 {
>> + port@0 {
>> + vpif_input_ch0: endpoint@0 {
>> reg = <0>;
>> bus-width = <8>;
>> - remote-endpoint = <&composite>;
>> + remote-endpoint = <&composite_in>;
>> };
>>
>> - vpif_ch1: endpoint@1 {
>> + vpif_input_ch1: endpoint@1 {
>> reg = <1>;
>> bus-width = <8>;
>> data-shift = <8>;
>> };
>> };
>> +
>> + port@1 {
>
> The binding doc says nothing about supporting a 2nd port.
>
I assumed that "It should contain at least one port child node" means
there can be more than one.
Thanks,
Bartosz
>
>> + vpif_output_ch0: endpoint@0 {
>> + reg = <0>;
>
> Don't need reg here.
>
>> + bus-width = <8>;
>> + remote-endpoint = <&composite_out>;
>> + };
>> + };
>> };
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-02-15 23:10 +0100 |
| Subject | Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port |
| Message-ID | <tbfVU-5G3-21@gated-at.bofh.it> |
| In reply to | #1575871 |
On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote: > This makes the example more or less correspond with the da850-evm > hardware setup. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > .../devicetree/bindings/media/ti,da850-vpif.txt | 35 ++++++++++++++++++---- > 1 file changed, 29 insertions(+), 6 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 04/10] ARM: dts: da850-evm: add the output port to the vpif node |
| Message-ID | <t8h7R-5ki-27@gated-at.bofh.it> |
| In reply to | #1575869 |
Extend the vpif node with an output port with a single channel.
NOTE: this is still just hardware description - the actual driver
is registered using pdata-quirks.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/boot/dts/da850-evm.dts | 14 +++++++++++---
arch/arm/boot/dts/da850.dtsi | 8 +++++++-
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 94938a3..3d6dd66 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -299,16 +299,24 @@
status = "okay";
/* VPIF capture port */
- port {
- vpif_ch0: endpoint@0 {
+ port@0 {
+ vpif_input_ch0: endpoint@0 {
reg = <0>;
bus-width = <8>;
};
- vpif_ch1: endpoint@1 {
+ vpif_input_ch1: endpoint@1 {
reg = <1>;
bus-width = <8>;
data-shift = <8>;
};
};
+
+ /* VPIF display port */
+ port@1 {
+ vpif_output_ch0: endpoint@0 {
+ reg = <0>;
+ bus-width = <8>;
+ };
+ };
};
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 69ec5e7..768a58c 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -494,7 +494,13 @@
status = "disabled";
/* VPIF capture port */
- port {
+ port@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+
+ /* VPIF display port */
+ port@1 {
#address-cells = <1>;
#size-cells = <0>;
};
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 06/10] ARM: davinci_all_defconfig: enable VPIF display modules |
| Message-ID | <t8h7R-5ki-31@gated-at.bofh.it> |
| In reply to | #1575869 |
Enable the VPIF display module and the video encoder present on the da850-evm UI board. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/configs/davinci_all_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index 7815a52..e188b02 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -137,9 +137,11 @@ CONFIG_DRM_DUMB_VGA_DAC=m CONFIG_MEDIA_SUPPORT=m CONFIG_MEDIA_CAMERA_SUPPORT=y CONFIG_V4L_PLATFORM_DRIVERS=y +CONFIG_VIDEO_DAVINCI_VPIF_DISPLAY=m CONFIG_VIDEO_DAVINCI_VPIF_CAPTURE=m # CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set CONFIG_VIDEO_TVP514X=m +CONFIG_VIDEO_ADV7343=m CONFIG_FB=y CONFIG_FIRMWARE_EDID=y CONFIG_FB_DA8XX=y -- 2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors |
| Message-ID | <t8h7R-5ki-33@gated-at.bofh.it> |
| In reply to | #1575869 |
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/boot/dts/da850-evm.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index c970b6e..94938a3 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -301,14 +301,14 @@
/* VPIF capture port */
port {
vpif_ch0: endpoint@0 {
- reg = <0>;
- bus-width = <8>;
+ reg = <0>;
+ bus-width = <8>;
};
vpif_ch1: endpoint@1 {
- reg = <1>;
- bus-width = <8>;
- data-shift = <8>;
+ reg = <1>;
+ bus-width = <8>;
+ data-shift = <8>;
};
};
};
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-13 19:30 +0100 |
| Subject | Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors |
| Message-ID | <tatxT-7jT-13@gated-at.bofh.it> |
| In reply to | #1575877 |
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> arch/arm/boot/dts/da850-evm.dts | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index c970b6e..94938a3 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -301,14 +301,14 @@
> /* VPIF capture port */
> port {
> vpif_ch0: endpoint@0 {
> - reg = <0>;
> - bus-width = <8>;
> + reg = <0>;
> + bus-width = <8>;
> };
>
> vpif_ch1: endpoint@1 {
> - reg = <1>;
> - bus-width = <8>;
> - data-shift = <8>;
> + reg = <1>;
> + bus-width = <8>;
> + data-shift = <8>;
> };
> };
> };
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
> Extend the vpif node with an output port with a single channel.
>
> NOTE: this is still just hardware description - the actual driver
> is registered using pdata-quirks.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/boot/dts/da850-evm.dts | 14 +++++++++++---
> arch/arm/boot/dts/da850.dtsi | 8 +++++++-
> 2 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index 94938a3..3d6dd66 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -299,16 +299,24 @@
> status = "okay";
>
> /* VPIF capture port */
> - port {
> - vpif_ch0: endpoint@0 {
> + port@0 {
> + vpif_input_ch0: endpoint@0 {
> reg = <0>;
> bus-width = <8>;
> };
>
> - vpif_ch1: endpoint@1 {
> + vpif_input_ch1: endpoint@1 {
> reg = <1>;
> bus-width = <8>;
> data-shift = <8>;
> };
> };
> +
> + /* VPIF display port */
> + port@1 {
> + vpif_output_ch0: endpoint@0 {
> + reg = <0>;
> + bus-width = <8>;
> + };
> + };
> };
> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
> index 69ec5e7..768a58c 100644
> --- a/arch/arm/boot/dts/da850.dtsi
> +++ b/arch/arm/boot/dts/da850.dtsi
> @@ -494,7 +494,13 @@
> status = "disabled";
>
> /* VPIF capture port */
> - port {
> + port@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +
> + /* VPIF display port */
> + port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
> };
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
> There's a stray tab in da850_vpif_legacy_init(). Remove it.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/mach-davinci/pdata-quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
> index a186513..94948c1 100644
> --- a/arch/arm/mach-davinci/pdata-quirks.c
> +++ b/arch/arm/mach-davinci/pdata-quirks.c
> @@ -111,7 +111,7 @@ static struct vpif_capture_config da850_vpif_capture_config = {
> static void __init da850_vpif_legacy_init(void)
> {
> int ret;
> -
> +
> /* LCDK doesn't have the 2nd TVP514x on CH1 */
> if (of_machine_is_compatible("ti,da850-lcdk"))
> da850_vpif_capture_config.subdev_count = 1;
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-13 19:40 +0100 |
| Subject | Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors |
| Message-ID | <tatHA-7nG-9@gated-at.bofh.it> |
| In reply to | #1575877 |
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
I'll fold this one into the original since it's not yet merged.
Kevin
> ---
> arch/arm/boot/dts/da850-evm.dts | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
> index c970b6e..94938a3 100644
> --- a/arch/arm/boot/dts/da850-evm.dts
> +++ b/arch/arm/boot/dts/da850-evm.dts
> @@ -301,14 +301,14 @@
> /* VPIF capture port */
> port {
> vpif_ch0: endpoint@0 {
> - reg = <0>;
> - bus-width = <8>;
> + reg = <0>;
> + bus-width = <8>;
> };
>
> vpif_ch1: endpoint@1 {
> - reg = <1>;
> - bus-width = <8>;
> - data-shift = <8>;
> + reg = <1>;
> + bus-width = <8>;
> + data-shift = <8>;
> };
> };
> };
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-13 22:10 +0100 |
| Subject | Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors |
| Message-ID | <taw2K-Bl-27@gated-at.bofh.it> |
| In reply to | #1579986 |
Kevin Hilman <khilman@baylibre.com> writes: > Bartosz Golaszewski <bgolaszewski@baylibre.com> writes: > >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I'll fold this one into the original since it's not yet merged. Oops, Sekhar has already merged this one to his v4.11/dt branch, so he can apply it (or fold it in.) Kevin
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-02-14 07:40 +0100 |
| Subject | Re: [PATCH 02/10] ARM: dts: da850-evm: fix whitespace errors |
| Message-ID | <taEWl-6yl-11@gated-at.bofh.it> |
| In reply to | #1580075 |
On Tuesday 14 February 2017 02:31 AM, Kevin Hilman wrote: > Kevin Hilman <khilman@baylibre.com> writes: > >> Bartosz Golaszewski <bgolaszewski@baylibre.com> writes: >> >>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> >> I'll fold this one into the original since it's not yet merged. > > Oops, Sekhar has already merged this one to his v4.11/dt branch, so he > can apply it (or fold it in.) Alright, I will apply this. Bartosz, for future, please add a commit description for trivial patches too. Even if its more or less just a rewording of subject line. Thanks, Sekhar
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 05/10] ARM: dts: da850: add vpif video display pins |
| Message-ID | <t8h7R-5ki-45@gated-at.bofh.it> |
| In reply to | #1575869 |
Add a new pinctrl sub-node for vpif display pins. Move VP_CLKIN3 and
VP_CLKIN2 to the display node where they actually belong (vide section
35.2.2 of the da850 datasheet).
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/boot/dts/da850-evm.dts | 2 +-
arch/arm/boot/dts/da850.dtsi | 17 +++++++++++++++--
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 3d6dd66..6db16ba 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -295,7 +295,7 @@
&vpif {
pinctrl-names = "default";
- pinctrl-0 = <&vpif_capture_pins>;
+ pinctrl-0 = <&vpif_capture_pins>, <&vpif_display_pins>;
status = "okay";
/* VPIF capture port */
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index 768a58c..d317bc5 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -218,8 +218,21 @@
0x3c 0x11111111 0xffffffff
/* VP_DIN[8..9] */
0x40 0x00000011 0x000000ff
- /* VP_CLKIN3, VP_CLKIN2 */
- 0x4c 0x00010100 0x000f0f00
+ >;
+ };
+ vpif_display_pins: vpif_display_pins {
+ pinctrl-single,bits = <
+ /* VP_DOUT[2..7] */
+ 0x40 0x11111100 0xffffff00
+ /* VP_DOUT[10..15,0..1] */
+ 0x44 0x11111111 0xffffffff
+ /* VP_DOUT[8..9] */
+ 0x48 0x00000011 0x000000ff
+ /*
+ * VP_CLKOUT3, VP_CLKIN3,
+ * VP_CLKOUT2, VP_CLKIN2
+ */
+ 0x4c 0x00111100 0x00ffff00
>;
};
};
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 01/10] media: dt-bindings: vpif: fix whitespace errors |
| Message-ID | <t8h7R-5ki-47@gated-at.bofh.it> |
| In reply to | #1575869 |
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
index 6d25d7f..9c7510b 100644
--- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
+++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
@@ -30,15 +30,15 @@ I2C-connected TVP5147 decoder:
port {
vpif_ch0: endpoint@0 {
- reg = <0>;
- bus-width = <8>;
- remote-endpoint = <&composite>;
+ reg = <0>;
+ bus-width = <8>;
+ remote-endpoint = <&composite>;
};
vpif_ch1: endpoint@1 {
- reg = <1>;
- bus-width = <8>;
- data-shift = <8>;
+ reg = <1>;
+ bus-width = <8>;
+ data-shift = <8>;
};
};
};
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-02-15 23:10 +0100 |
| Subject | Re: [PATCH 01/10] media: dt-bindings: vpif: fix whitespace errors |
| Message-ID | <tbfVT-5G3-11@gated-at.bofh.it> |
| In reply to | #1575881 |
On Tue, Feb 07, 2017 at 05:41:14PM +0100, Bartosz Golaszewski wrote: > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
[toc] | [prev] | [next] | [standalone]
| From | Bartosz Golaszewski <bgolaszewski@baylibre.com> |
|---|---|
| Date | 2017-02-07 17:50 +0100 |
| Subject | [PATCH 07/10] ARM: davinci: fix a whitespace error |
| Message-ID | <t8h7R-5ki-49@gated-at.bofh.it> |
| In reply to | #1575869 |
There's a stray tab in da850_vpif_legacy_init(). Remove it.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/mach-davinci/pdata-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
index a186513..94948c1 100644
--- a/arch/arm/mach-davinci/pdata-quirks.c
+++ b/arch/arm/mach-davinci/pdata-quirks.c
@@ -111,7 +111,7 @@ static struct vpif_capture_config da850_vpif_capture_config = {
static void __init da850_vpif_legacy_init(void)
{
int ret;
-
+
/* LCDK doesn't have the 2nd TVP514x on CH1 */
if (of_machine_is_compatible("ti,da850-lcdk"))
da850_vpif_capture_config.subdev_count = 1;
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-13 19:40 +0100 |
| Subject | Re: [PATCH 07/10] ARM: davinci: fix a whitespace error |
| Message-ID | <tatHA-7nG-23@gated-at.bofh.it> |
| In reply to | #1575883 |
Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
> There's a stray tab in da850_vpif_legacy_init(). Remove it.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Folding into the original,
Kevin
> ---
> arch/arm/mach-davinci/pdata-quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/pdata-quirks.c b/arch/arm/mach-davinci/pdata-quirks.c
> index a186513..94948c1 100644
> --- a/arch/arm/mach-davinci/pdata-quirks.c
> +++ b/arch/arm/mach-davinci/pdata-quirks.c
> @@ -111,7 +111,7 @@ static struct vpif_capture_config da850_vpif_capture_config = {
> static void __init da850_vpif_legacy_init(void)
> {
> int ret;
> -
> +
> /* LCDK doesn't have the 2nd TVP514x on CH1 */
> if (of_machine_is_compatible("ti,da850-lcdk"))
> da850_vpif_capture_config.subdev_count = 1;
[toc] | [prev] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-13 22:10 +0100 |
| Subject | Re: [PATCH 07/10] ARM: davinci: fix a whitespace error |
| Message-ID | <taw2K-Bl-17@gated-at.bofh.it> |
| In reply to | #1579988 |
Kevin Hilman <khilman@baylibre.com> writes: > Bartosz Golaszewski <bgolaszewski@baylibre.com> writes: > >> There's a stray tab in da850_vpif_legacy_init(). Remove it. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Folding into the original, Looks like the version in Sekhar's v4.11/soc branch already has this fixed. Kevin
[toc] | [prev] | [next] | [standalone]
| From | Sekhar Nori <nsekhar@ti.com> |
|---|---|
| Date | 2017-02-13 10:30 +0100 |
| Message-ID | <tal7j-1Oy-3@gated-at.bofh.it> |
| In reply to | #1575869 |
Hi Bartosz, On Tuesday 07 February 2017 10:11 PM, Bartosz Golaszewski wrote: > The following series adds support for v4l2 display on da850-evm with > a UI board in device tree boot mode. > > Patches 1/10 - 5/10 deal with the device tree: we fix whitespace > errors in dts files and bindings, extend the example and the dts for > da850-evm with the output port and address the pinmuxing. > > Patch 6/10 enables the relevant modules in the defconfig file. > > Patches 7/10 and 8/10 fix two already existing bugs encountered > during development. > > Patch 9/10 make it possible to use a different i2c adapter in the > vpif display driver. > > The last patch adds the pdata quirks necessary to enable v4l2 display. > > Tested with a modified version of yavta[1] as gstreamer support for > v4l2 seems to be broken and results in picture artifacts. > > [1] https://github.com/brgl/yavta davinci/vpif-display Can you also share the command line you used ? Thanks, Sekhar
[toc] | [prev] | [next] | [standalone]
Page 1 of 2 [1] 2 Next page →
Back to top | Article view | linux.kernel
csiph-web