Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581707

Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port
Date 2017-02-15 23:10 +0100
Message-ID <tbfVT-5G3-9@gated-at.bofh.it> (permalink)
References <t8h7P-5ki-3@gated-at.bofh.it> <t8h7Q-5ki-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> This makes the example more or less correspond with the da850-evm
> hardware setup.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  .../devicetree/bindings/media/ti,da850-vpif.txt    | 35 ++++++++++++++++++----
>  1 file changed, 29 insertions(+), 6 deletions(-)

Spoke too soon...

> 
> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> index 9c7510b..543f6f3 100644
> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
>  		reg = <0x217000 0x1000>;
>  		interrupts = <92>;
>  
> -		port {
> -			vpif_ch0: endpoint@0 {
> +		port@0 {
> +			vpif_input_ch0: endpoint@0 {
>  				reg = <0>;
>  				bus-width = <8>;
> -				remote-endpoint = <&composite>;
> +				remote-endpoint = <&composite_in>;
>  			};
>  
> -			vpif_ch1: endpoint@1 {
> +			vpif_input_ch1: endpoint@1 {
>  				reg = <1>;
>  				bus-width = <8>;
>  				data-shift = <8>;
>  			};
>  		};
> +
> +		port@1 {

The binding doc says nothing about supporting a 2nd port. 


> +			vpif_output_ch0: endpoint@0 {
> +				reg = <0>;

Don't need reg here.

> +				bus-width = <8>;
> +				remote-endpoint = <&composite_out>;
> +			};
> +		};
>  	};

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with  an output port Rob Herring <robh@kernel.org> - 2017-02-15 23:10 +0100
  Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with an output port Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-02-16 08:40 +0100
  Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with  an output port Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-02-16 17:10 +0100

csiph-web