Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579812 > unrolled thread

[PATCH 0/3] staging: wlan-ng: align else if statement to coding standard

Started byMaksymilian Piechota <maksymilianpiechota@gmail.com>
First post2017-02-13 15:30 +0100
Last post2017-02-13 15:40 +0100
Articles 7 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] staging: wlan-ng: align else if statement to coding  standard Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-13 15:30 +0100
    [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the  end of line Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-13 15:30 +0100
      Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at  the end of line Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-14 18:20 +0100
        Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at  the end of line Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-15 13:00 +0100
          Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at  the end of line Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-15 15:30 +0100
    [PATCHv6 3/3] staging: wlan-ng: realign else if continuation Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-13 15:40 +0100
    [PATCHv6 2/3] staging: wlan-ng: move else if statement to a single  line Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-13 15:40 +0100

#1579812 — [PATCH 0/3] staging: wlan-ng: align else if statement to coding standard

FromMaksymilian Piechota <maksymilianpiechota@gmail.com>
Date2017-02-13 15:30 +0100
Subject[PATCH 0/3] staging: wlan-ng: align else if statement to coding standard
Message-ID<tapND-4Q3-5@gated-at.bofh.it>
PATCHv0:

  - Spaces replaced with tabs

Maksymilian Piechota (1):
  staging: wlan-ng: This patch fixes the checkpatch.pl warning:

else if statement still did not fulfill coding standard requirements.


PATCHv2:

  - else if statement moved to single line

Maksymilian Piechota (1):
  staging: wlan-ng: This patch fixes the checkpatch.pl warning:

Subject was not precise.

PATCHv3:

  - Subject is more precise
  - Changelog text describe every change  

Maksymilian Piechota (1):
  staging: lustre: align else if statement to coding standard

Too much changes for one patch.

PATCHv4:
  
  - Previous patch breaked up to particular patches for every change

Maksymilian Piechota (2):
  staging: lustre: move logical continuations at the end of line
  staging: lustre: move else if statement to a single line

Continuation of the statement should be realigned

PATCHv5:

  - Wrong prefixes in commits and patches titles changed
  - Else if continuation realigned 

Maksymilian Piechota (3):
  staging: wlan-ng: move logical continuations at the end of line
  staging: wlan-ng: move else if statement to a single line
  staging: wlan-ng: realign else if continuation

Lack of patches history. No changelog text for particular patches

PATCHv6:

  - changelog text for patches added
  - patches history added

Maksymilian Piechota (3):
  staging: wlan-ng: move logical continuations at the end of line
  staging: wlan-ng: move else if statement to a single line
  staging: wlan-ng: realign else if continuation
 
drivers/staging/wlan-ng/prism2mgmt.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)


-- 
2.1.4

[toc] | [next] | [standalone]

#1579814 — [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

FromMaksymilian Piechota <maksymilianpiechota@gmail.com>
Date2017-02-13 15:30 +0100
Subject[PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line
Message-ID<tapND-4Q3-13@gated-at.bofh.it>
In reply to#1579812
move logical continuations at the end of line

Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 16fb2d3..64a9ebc 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
 			hw->sniffhdr = 0;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else
-		    if ((msg->wlanheader.status ==
-			 P80211ENUM_msgitem_status_data_ok)
-			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
+		    if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && 
+			(msg->wlanheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 1;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else {
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1580699 — Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-02-14 18:20 +0100
SubjectRe: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line
Message-ID<taOVI-4DR-7@gated-at.bofh.it>
In reply to#1579814
On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote:
> move logical continuations at the end of line
> 
> Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 16fb2d3..64a9ebc 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
>  			hw->sniffhdr = 0;
>  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
>  		} else
> -		    if ((msg->wlanheader.status ==
> -			 P80211ENUM_msgitem_status_data_ok)
> -			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> +		    if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && 
> +			(msg->wlanheader.data == P80211ENUM_truth_true)) {
>  			hw->sniffhdr = 1;
>  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
>  		} else {

This patch has checkpatch.pl errors.  Please always use checkpatch so
you don't get emails from grumpy maintainers telling you to fix the
checkpatch errors :)

Please fix up and resend the whole series.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1581255 — Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

FromMaksymilian Piechota <maksymilianpiechota@gmail.com>
Date2017-02-15 13:00 +0100
SubjectRe: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line
Message-ID<tb6pz-7Tn-15@gated-at.bofh.it>
In reply to#1580699
On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote:
> On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote:
> > move logical continuations at the end of line
> > 
> > Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> > index 16fb2d3..64a9ebc 100644
> > --- a/drivers/staging/wlan-ng/prism2mgmt.c
> > +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> > @@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> >  			hw->sniffhdr = 0;
> >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> >  		} else
> > -		    if ((msg->wlanheader.status ==
> > -			 P80211ENUM_msgitem_status_data_ok)
> > -			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> > +		    if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && 
> > +			(msg->wlanheader.data == P80211ENUM_truth_true)) {
> >  			hw->sniffhdr = 1;
> >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> >  		} else {
> 
> This patch has checkpatch.pl errors.  Please always use checkpatch so
> you don't get emails from grumpy maintainers telling you to fix the
> checkpatch errors :)
> 
> Please fix up and resend the whole series.
> 
> thanks,
> 
> greg k-h

of course it has. Few patches ago I've sent all changes in one patch so
there was no errors. Then You asked me to break up every change to particular
commits, so there are checkpatch errors between them. PATCH 3/3 solves
all errors.

So how should I commit this changes, finally? I feel bit lost.

[toc] | [prev] | [next] | [standalone]

#1581348 — Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-02-15 15:30 +0100
SubjectRe: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line
Message-ID<tb8KK-170-25@gated-at.bofh.it>
In reply to#1581255
On Wed, Feb 15, 2017 at 06:53:43AM -0500, Maksymilian Piechota wrote:
> On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote:
> > On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote:
> > > move logical continuations at the end of line
> > > 
> > > Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> > > ---
> > >  drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> > > index 16fb2d3..64a9ebc 100644
> > > --- a/drivers/staging/wlan-ng/prism2mgmt.c
> > > +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> > > @@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> > >  			hw->sniffhdr = 0;
> > >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> > >  		} else
> > > -		    if ((msg->wlanheader.status ==
> > > -			 P80211ENUM_msgitem_status_data_ok)
> > > -			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> > > +		    if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && 
> > > +			(msg->wlanheader.data == P80211ENUM_truth_true)) {
> > >  			hw->sniffhdr = 1;
> > >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> > >  		} else {
> > 
> > This patch has checkpatch.pl errors.  Please always use checkpatch so
> > you don't get emails from grumpy maintainers telling you to fix the
> > checkpatch errors :)
> > 
> > Please fix up and resend the whole series.
> > 
> > thanks,
> > 
> > greg k-h
> 
> of course it has. Few patches ago I've sent all changes in one patch so
> there was no errors. Then You asked me to break up every change to particular
> commits, so there are checkpatch errors between them. PATCH 3/3 solves
> all errors.

But you added NEW errors in this patch, which isn't ok at all.  Don't
make a new error and then remove it in a later one, that's just crazy!

(hint, trailing whitespace...)

Also, you made this change in a way that added another new problem (too
long of a line), you don't have to do that in order to fix this one
warning.

Please fix up and resend.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1579817 — [PATCHv6 3/3] staging: wlan-ng: realign else if continuation

FromMaksymilian Piechota <maksymilianpiechota@gmail.com>
Date2017-02-13 15:40 +0100
Subject[PATCHv6 3/3] staging: wlan-ng: realign else if continuation
Message-ID<tapXj-4TG-3@gated-at.bofh.it>
In reply to#1579812
realign else if continuation

Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index af83f2a..5277f36 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1308,7 +1308,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
 			hw->sniffhdr = 0;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) &&
-			(msg->wlanheader.data == P80211ENUM_truth_true)) {
+			   (msg->wlanheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 1;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
 		} else {
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1579818 — [PATCHv6 2/3] staging: wlan-ng: move else if statement to a single line

FromMaksymilian Piechota <maksymilianpiechota@gmail.com>
Date2017-02-13 15:40 +0100
Subject[PATCHv6 2/3] staging: wlan-ng: move else if statement to a single line
Message-ID<tapXj-4TG-11@gated-at.bofh.it>
In reply to#1579812
move else if statement to a single line

Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
 drivers/staging/wlan-ng/prism2mgmt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 64a9ebc..af83f2a 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
 		    && (msg->prismheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 0;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
-		} else
-		    if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && 
+		} else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) &&
 			(msg->wlanheader.data == P80211ENUM_truth_true)) {
 			hw->sniffhdr = 1;
 			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
-- 
2.1.4

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web