Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line
Date	2017-02-15 15:30 +0100
Message-ID	<tb8KK-170-25@gated-at.bofh.it> (permalink)
References	<tapND-4Q3-5@gated-at.bofh.it> <tapND-4Q3-13@gated-at.bofh.it> <taOVI-4DR-7@gated-at.bofh.it> <tb6pz-7Tn-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 15, 2017 at 06:53:43AM -0500, Maksymilian Piechota wrote:
> On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote:
> > On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote:
> > > move logical continuations at the end of line
> > > 
> > > Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> > > ---
> > >  drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> > > index 16fb2d3..64a9ebc 100644
> > > --- a/drivers/staging/wlan-ng/prism2mgmt.c
> > > +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> > > @@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> > >  			hw->sniffhdr = 0;
> > >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> > >  		} else
> > > -		    if ((msg->wlanheader.status ==
> > > -			 P80211ENUM_msgitem_status_data_ok)
> > > -			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> > > +		    if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && 
> > > +			(msg->wlanheader.data == P80211ENUM_truth_true)) {
> > >  			hw->sniffhdr = 1;
> > >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> > >  		} else {
> > 
> > This patch has checkpatch.pl errors.  Please always use checkpatch so
> > you don't get emails from grumpy maintainers telling you to fix the
> > checkpatch errors :)
> > 
> > Please fix up and resend the whole series.
> > 
> > thanks,
> > 
> > greg k-h
> 
> of course it has. Few patches ago I've sent all changes in one patch so
> there was no errors. Then You asked me to break up every change to particular
> commits, so there are checkpatch errors between them. PATCH 3/3 solves
> all errors.

But you added NEW errors in this patch, which isn't ok at all.  Don't
make a new error and then remove it in a later one, that's just crazy!

(hint, trailing whitespace...)

Also, you made this change in a way that added another new problem (too
long of a line), you don't have to do that in order to fix this one
warning.

Please fix up and resend.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at  the end of line Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-14 18:20 +0100
  Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at  the end of line Maksymilian Piechota <maksymilianpiechota@gmail.com> - 2017-02-15 13:00 +0100
    Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at  the end of line Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-15 15:30 +0100

csiph-web