Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580853 > unrolled thread
| Started by | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-02-14 21:40 +0100 |
| Last post | 2017-02-15 04:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: xgifb: function definition argument should also have an identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-14 21:40 +0100
Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name Joe Perches <joe@perches.com> - 2017-02-14 21:50 +0100
Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name Joe Perches <joe@perches.com> - 2017-02-15 04:40 +0100
| From | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-02-14 21:40 +0100 |
| Subject | [PATCH] staging: xgifb: function definition argument should also have an identifier name |
| Message-ID | <taS3g-6vH-25@gated-at.bofh.it> |
function definition argument 'struct vb_device_info *' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/staging/xgifb/vb_init.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h index 500cabe41a3c..022486a516d6 100644 --- a/drivers/staging/xgifb/vb_init.h +++ b/drivers/staging/xgifb/vb_init.h @@ -1,6 +1,6 @@ #ifndef _VBINIT_ #define _VBINIT_ unsigned char XGIInitNew(struct pci_dev *pdev); -void XGIRegInit(struct vb_device_info *, unsigned long); +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long); #endif -- 2.11.0
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-14 21:50 +0100 |
| Subject | Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name |
| Message-ID | <taScV-6zd-7@gated-at.bofh.it> |
| In reply to | #1580853 |
On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote: > function definition argument 'struct vb_device_info *' should also have > an identifier name. [] > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h [] > @@ -1,6 +1,6 @@ > #ifndef _VBINIT_ > #define _VBINIT_ > unsigned char XGIInitNew(struct pci_dev *pdev); > -void XGIRegInit(struct vb_device_info *, unsigned long); > +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long); Why do one argument but not the other?
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-15 04:40 +0100 |
| Subject | Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name |
| Message-ID | <taYBI-2o3-5@gated-at.bofh.it> |
| In reply to | #1580861 |
On Wed, 2017-02-15 at 09:01 +0530, Arushi Singhal wrote: > Hi Joe > Sorry but I am unable to find the identifier of "unsigned long" .Shall you > please help me in how to find the identifier. > Thanks > Arushi Singhal $ git grep -w XGIRegInit drivers/staging/xgifb/XGI_main_26.c:void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr) > On Wed, Feb 15, 2017 at 2:13 AM, Joe Perches <joe@perches.com> wrote: > > > On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote: > > > function definition argument 'struct vb_device_info *' should also have > > > an identifier name. > > > > [] > > > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_ > > > > init.h > > [] > > > @@ -1,6 +1,6 @@ > > > #ifndef _VBINIT_ > > > #define _VBINIT_ > > > unsigned char XGIInitNew(struct pci_dev *pdev); > > > -void XGIRegInit(struct vb_device_info *, unsigned long); > > > +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long); > > > > Why do one argument but not the other? > > > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web