Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name
Date	2017-02-15 04:40 +0100
Message-ID	<taYBI-2o3-5@gated-at.bofh.it> (permalink)
References	<taS3g-6vH-25@gated-at.bofh.it> <taScV-6zd-7@gated-at.bofh.it> <taYBI-2o3-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 2017-02-15 at 09:01 +0530, Arushi Singhal wrote:
> Hi Joe
> Sorry but I am unable to find the identifier of "unsigned long" .Shall you
> please help me in how to find the identifier.
> Thanks
> Arushi Singhal

$ git grep -w XGIRegInit
drivers/staging/xgifb/XGI_main_26.c:void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr)

> On Wed, Feb 15, 2017 at 2:13 AM, Joe Perches <joe@perches.com> wrote:
> 
> > On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote:
> > > function definition argument 'struct vb_device_info *' should also have
> > > an identifier name.
> > 
> > []
> > > diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_
> > 
> > init.h
> > []
> > > @@ -1,6 +1,6 @@
> > >  #ifndef _VBINIT_
> > >  #define _VBINIT_
> > >  unsigned char XGIInitNew(struct pci_dev *pdev);
> > > -void XGIRegInit(struct vb_device_info *, unsigned long);
> > > +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long);
> > 
> > Why do one argument but not the other?
> > 
> >

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: xgifb: function definition argument should also  have an identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-14 21:40 +0100
  Re: [PATCH] staging: xgifb: function definition argument should  also have an identifier name Joe Perches <joe@perches.com> - 2017-02-14 21:50 +0100
    Re: [PATCH] staging: xgifb: function definition argument should  also have an identifier name Joe Perches <joe@perches.com> - 2017-02-15 04:40 +0100

csiph-web