Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580707 > unrolled thread

Re: [PATCH] usb: musb: add code comment for clarification

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] usb: musb: add code comment for clarification Greg KH <gregkh@linuxfoundation.org> - 2017-02-14 18:40 +0100
    Re: [PATCH] usb: musb: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 19:20 +0100
      [PATCH v2] usb: musb: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 19:30 +0100
        Re: [PATCH v2] usb: musb: add code comment for clarification Greg KH <gregkh@linuxfoundation.org> - 2017-02-14 19:30 +0100
          Re: [PATCH v2] usb: musb: add code comment for clarification Bin Liu <b-liu@ti.com> - 2017-02-14 20:00 +0100

#1580707 — Re: [PATCH] usb: musb: add code comment for clarification

On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional.
> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/usb/musb/musb_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 892088f..1aec986 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb
> *musb)
> 
>                         return;
>                 }
> +               /* fall through */
>         case MUSB_QUIRK_A_DISCONNECT_19:
>                 if (musb->quirk_retries--) {
>                         musb_dbg(musb,

The tabs are all gone from this patch, and it's line-wrapped, making it
impossible to be applied :(

Can you please fix this and resend?

thanks,

greg k-h

[toc] | [next] | [standalone]

#1580734

Quoting Greg KH <gregkh@linuxfoundation.org>:

> On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote:
>> Add code comment to make it clear that the fall-through is intentional.
>> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/usb/musb/musb_core.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>> index 892088f..1aec986 100644
>> --- a/drivers/usb/musb/musb_core.c
>> +++ b/drivers/usb/musb/musb_core.c
>> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb
>> *musb)
>>
>>                         return;
>>                 }
>> +               /* fall through */
>>         case MUSB_QUIRK_A_DISCONNECT_19:
>>                 if (musb->quirk_retries--) {
>>                         musb_dbg(musb,
>
> The tabs are all gone from this patch, and it's line-wrapped, making it
> impossible to be applied :(
>
> Can you please fix this and resend?
>

OK. I'll send it shortly.

Thanks
--
Gustavo A. R. Silva

[toc] | [prev] | [next] | [standalone]

#1580743 — [PATCH v2] usb: musb: add code comment for clarification

Add code comment to make it clear that the fall-through is intentional.
Read the link for more details: https://lkml.org/lkml/2017/2/9/292

Addresses-Coverity-ID: 1397608
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
 Fix tabs and line-wrapping in previous patch.

 drivers/usb/musb/musb_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 892088f..d8bae6c 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb *musb)
 
 			return;
 		}
+		/* fall through */
 	case MUSB_QUIRK_A_DISCONNECT_19:
 		if (musb->quirk_retries--) {
 			musb_dbg(musb,
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1580746 — Re: [PATCH v2] usb: musb: add code comment for clarification

On Tue, Feb 14, 2017 at 12:20:39PM -0600, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional.
> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
> 
> Addresses-Coverity-ID: 1397608
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
>  Fix tabs and line-wrapping in previous patch.

Thanks for this.  Bin, I've applied this to my tree so it makes it into
4.11-rc1.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1580758 — Re: [PATCH v2] usb: musb: add code comment for clarification

On Tue, Feb 14, 2017 at 10:25:11AM -0800, Greg KH wrote:
> On Tue, Feb 14, 2017 at 12:20:39PM -0600, Gustavo A. R. Silva wrote:
> > Add code comment to make it clear that the fall-through is intentional.
> > Read the link for more details: https://lkml.org/lkml/2017/2/9/292
> > 
> > Addresses-Coverity-ID: 1397608
> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > ---
> > Changes in v2:
> >  Fix tabs and line-wrapping in previous patch.
> 
> Thanks for this.  Bin, I've applied this to my tree so it makes it into
> 4.11-rc1.

Thanks Greg for take it to v4.11.

Regards,
-Bin.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web