Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580692 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-02-14 18:10 +0100 |
| Last post | 2017-02-15 06:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] crypto: cavium: fix Kconfig dependencies Arnd Bergmann <arnd@arndb.de> - 2017-02-14 18:10 +0100
Re: [PATCH] crypto: cavium: fix Kconfig dependencies Randy Dunlap <rdunlap@infradead.org> - 2017-02-14 19:30 +0100
Re: [PATCH] crypto: cavium: fix Kconfig dependencies Herbert Xu <herbert@gondor.apana.org.au> - 2017-02-15 06:40 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-02-14 18:10 +0100 |
| Subject | [PATCH] crypto: cavium: fix Kconfig dependencies |
| Message-ID | <taOM3-4Ah-57@gated-at.bofh.it> |
The driver fails to build if MSI support is disabled:
In file included from /git/arm-soc/drivers/crypto/cavium/cpt/cptpf_main.c:18:0:
drivers/crypto/cavium/cpt/cptpf.h:57:20: error: array type has incomplete element type 'struct msix_entry'
struct msix_entry msix_entries[CPT_PF_MSIX_VECTORS];
^~~~~~~~~~~~
drivers/crypto/cavium/cpt/cptpf_main.c: In function 'cpt_enable_msix':
drivers/crypto/cavium/cpt/cptpf_main.c:344:8: error: implicit declaration of function 'pci_enable_msix';did you mean 'cpt_enable_msix'? [-Werror=implicit-function-declaration]
On the other hand, it doesn't seem to have any build dependency on ARCH_THUNDER,
so let's allow compile-testing to catch this kind of problem more easily.
The 64-bit dependency is needed for the use of readq/writeq.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/cavium/cpt/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/cavium/cpt/Kconfig b/drivers/crypto/cavium/cpt/Kconfig
index 247f1cbbefc1..cbd51b1aa046 100644
--- a/drivers/crypto/cavium/cpt/Kconfig
+++ b/drivers/crypto/cavium/cpt/Kconfig
@@ -7,7 +7,8 @@ config CRYPTO_DEV_CPT
config CAVIUM_CPT
tristate "Cavium Cryptographic Accelerator driver"
- depends on ARCH_THUNDER
+ depends on ARCH_THUNDER || COMPILE_TEST
+ depends on PCI_MSI && 64BIT
select CRYPTO_DEV_CPT
help
Support for Cavium CPT block found in octeon-tx series of
--
2.9.0
[toc] | [next] | [standalone]
| From | Randy Dunlap <rdunlap@infradead.org> |
|---|---|
| Date | 2017-02-14 19:30 +0100 |
| Message-ID | <taQ1s-5hv-19@gated-at.bofh.it> |
| In reply to | #1580692 |
On 02/14/17 09:09, David Daney wrote: > On 02/14/2017 09:07 AM, Arnd Bergmann wrote: >> The driver fails to build if MSI support is disabled: >> >> In file included from /git/arm-soc/drivers/crypto/cavium/cpt/cptpf_main.c:18:0: >> drivers/crypto/cavium/cpt/cptpf.h:57:20: error: array type has incomplete element type 'struct msix_entry' >> struct msix_entry msix_entries[CPT_PF_MSIX_VECTORS]; >> ^~~~~~~~~~~~ >> drivers/crypto/cavium/cpt/cptpf_main.c: In function 'cpt_enable_msix': >> drivers/crypto/cavium/cpt/cptpf_main.c:344:8: error: implicit declaration of function 'pci_enable_msix';did you mean 'cpt_enable_msix'? [-Werror=implicit-function-declaration] >> >> On the other hand, it doesn't seem to have any build dependency on ARCH_THUNDER, >> so let's allow compile-testing to catch this kind of problem more easily. >> The 64-bit dependency is needed for the use of readq/writeq. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> drivers/crypto/cavium/cpt/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/crypto/cavium/cpt/Kconfig b/drivers/crypto/cavium/cpt/Kconfig >> index 247f1cbbefc1..cbd51b1aa046 100644 >> --- a/drivers/crypto/cavium/cpt/Kconfig >> +++ b/drivers/crypto/cavium/cpt/Kconfig >> @@ -7,7 +7,8 @@ config CRYPTO_DEV_CPT >> >> config CAVIUM_CPT >> tristate "Cavium Cryptographic Accelerator driver" >> - depends on ARCH_THUNDER >> + depends on ARCH_THUNDER || COMPILE_TEST >> + depends on PCI_MSI && 64BIT > > > Perhaps we should select PCI and PCI_MSI instead. > > These systems cannot function without those. Then the "depends" (and hence the patch) is correct. A driver should not enable all of PCI if it is disabled for some other reason. >> select CRYPTO_DEV_CPT >> help >> Support for Cavium CPT block found in octeon-tx series of >> > -- ~Randy
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2017-02-15 06:40 +0100 |
| Message-ID | <tb0tQ-3XX-5@gated-at.bofh.it> |
| In reply to | #1580692 |
On Tue, Feb 14, 2017 at 06:07:31PM +0100, Arnd Bergmann wrote: > The driver fails to build if MSI support is disabled: > > In file included from /git/arm-soc/drivers/crypto/cavium/cpt/cptpf_main.c:18:0: > drivers/crypto/cavium/cpt/cptpf.h:57:20: error: array type has incomplete element type 'struct msix_entry' > struct msix_entry msix_entries[CPT_PF_MSIX_VECTORS]; > ^~~~~~~~~~~~ > drivers/crypto/cavium/cpt/cptpf_main.c: In function 'cpt_enable_msix': > drivers/crypto/cavium/cpt/cptpf_main.c:344:8: error: implicit declaration of function 'pci_enable_msix';did you mean 'cpt_enable_msix'? [-Werror=implicit-function-declaration] > > On the other hand, it doesn't seem to have any build dependency on ARCH_THUNDER, > so let's allow compile-testing to catch this kind of problem more easily. > The 64-bit dependency is needed for the use of readq/writeq. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web