Re: [PATCH] crypto: cavium: fix Kconfig dependencies

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: cavium: fix Kconfig dependencies
Date	2017-02-15 06:40 +0100
Message-ID	<tb0tQ-3XX-5@gated-at.bofh.it> (permalink)
References	<taOM3-4Ah-57@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 14, 2017 at 06:07:31PM +0100, Arnd Bergmann wrote:
> The driver fails to build if MSI support is disabled:
> 
> In file included from /git/arm-soc/drivers/crypto/cavium/cpt/cptpf_main.c:18:0:
> drivers/crypto/cavium/cpt/cptpf.h:57:20: error: array type has incomplete element type 'struct msix_entry'
>   struct msix_entry msix_entries[CPT_PF_MSIX_VECTORS];
>                     ^~~~~~~~~~~~
> drivers/crypto/cavium/cpt/cptpf_main.c: In function 'cpt_enable_msix':
> drivers/crypto/cavium/cpt/cptpf_main.c:344:8: error: implicit declaration of function 'pci_enable_msix';did you mean 'cpt_enable_msix'? [-Werror=implicit-function-declaration]
> 
> On the other hand, it doesn't seem to have any build dependency on ARCH_THUNDER,
> so let's allow compile-testing to catch this kind of problem more easily.
> The 64-bit dependency is needed for the use of readq/writeq.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: cavium: fix Kconfig dependencies Arnd Bergmann <arnd@arndb.de> - 2017-02-14 18:10 +0100
  Re: [PATCH] crypto: cavium: fix Kconfig dependencies Randy Dunlap <rdunlap@infradead.org> - 2017-02-14 19:30 +0100
  Re: [PATCH] crypto: cavium: fix Kconfig dependencies Herbert Xu <herbert@gondor.apana.org.au> - 2017-02-15 06:40 +0100

csiph-web