Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1680886 > unrolled thread
| Started by | Pawel Moll <pawel.moll@arm.com> |
|---|---|
| First post | 2017-07-04 13:30 +0200 |
| Last post | 2017-07-04 13:30 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] bus: arm-ccn: constify attribute_group structures. Pawel Moll <pawel.moll@arm.com> - 2017-07-04 13:30 +0200
| From | Pawel Moll <pawel.moll@arm.com> |
|---|---|
| Date | 2017-07-04 13:30 +0200 |
| Subject | Re: [PATCH] bus: arm-ccn: constify attribute_group structures. |
| Message-ID | <tZubL-7zh-7@gated-at.bofh.it> |
On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 9074 5592 416 15082 3aea drivers/bus/arm-ccn.o > > File size After adding 'const': > text data bss dec hex filename > 9327 5336 416 15079 3ae7 drivers/bus/arm-ccn.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Looks fine to me. I'll queue it for the next time I push out CCN driver fixes (no dates promised, though...) Thanks! Paweł
Back to top | Article view | linux.kernel
csiph-web