Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1680886
| From | Pawel Moll <pawel.moll@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] bus: arm-ccn: constify attribute_group structures. |
| Date | 2017-07-04 13:30 +0200 |
| Message-ID | <tZubL-7zh-7@gated-at.bofh.it> (permalink) |
| References | <tZ47E-6mA-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2017-07-03 at 13:01 +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 9074 5592 416 15082 3aea drivers/bus/arm-ccn.o > > File size After adding 'const': > text data bss dec hex filename > 9327 5336 416 15079 3ae7 drivers/bus/arm-ccn.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Looks fine to me. I'll queue it for the next time I push out CCN driver fixes (no dates promised, though...) Thanks! Paweł
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] bus: arm-ccn: constify attribute_group structures. Pawel Moll <pawel.moll@arm.com> - 2017-07-04 13:30 +0200
csiph-web