Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681704 > unrolled thread

Re: [PATCH 01/37] Revert "android: binder: Sanity check at binder ioctl"

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 01/37] Revert "android: binder: Sanity check at binder  ioctl" Greg KH <gregkh@linuxfoundation.org> - 2017-07-05 20:50 +0200

#1681704 — Re: [PATCH 01/37] Revert "android: binder: Sanity check at binder ioctl"

On Wed, Jul 05, 2017 at 09:08:48AM -0700, Todd Kjos wrote:
> It is reverted here because if we keep it, it would need to be refactored as
> part of this patchset since vma_vm_mm is no longer in struct binder_proc (moved
> to binder_alloc). The patch introduces a race condition in the driver and an
> attempt to fix it was submitted in "[PATCH v2] android: binder: fix dangling
> pointer comparison" and the conclusion then was to revert this patch. After
> discussing with Arve we decided reverting now was better than refactoring it to
> work with FGL.
> 
> Do you want me to add rationale to the commit message?

Yes, please do :)

thanks,

greg k-h

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web