Re: [PATCH 01/37] Revert "android: binder: Sanity check at binder ioctl"

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/37] Revert "android: binder: Sanity check at binder ioctl"
Date	2017-07-05 20:50 +0200
Message-ID	<tZXx7-1xL-5@gated-at.bofh.it> (permalink)
References	<tXMZb-354-3@gated-at.bofh.it> <tXMZc-354-13@gated-at.bofh.it> <tZ5Gq-7vd-31@gated-at.bofh.it> <tZXx7-1xL-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 05, 2017 at 09:08:48AM -0700, Todd Kjos wrote:
> It is reverted here because if we keep it, it would need to be refactored as
> part of this patchset since vma_vm_mm is no longer in struct binder_proc (moved
> to binder_alloc). The patch introduces a race condition in the driver and an
> attempt to fix it was submitted in "[PATCH v2] android: binder: fix dangling
> pointer comparison" and the conclusion then was to revert this patch. After
> discussing with Arve we decided reverting now was better than refactoring it to
> work with FGL.
> 
> Do you want me to add rationale to the commit message?

Yes, please do :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 01/37] Revert "android: binder: Sanity check at binder  ioctl" Greg KH <gregkh@linuxfoundation.org> - 2017-07-05 20:50 +0200

csiph-web