Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1681585 > unrolled thread
| Started by | David Howells <dhowells@redhat.com> |
|---|---|
| First post | 2017-07-05 17:30 +0200 |
| Last post | 2017-07-10 18:20 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options David Howells <dhowells@redhat.com> - 2017-07-05 17:30 +0200
Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options David Howells <dhowells@redhat.com> - 2017-07-05 17:40 +0200
Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options Steven Rostedt <rostedt@goodmis.org> - 2017-07-05 21:00 +0200
Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options Steven Rostedt <rostedt@goodmis.org> - 2017-07-05 17:40 +0200
Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-05 21:00 +0200
Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options David Sterba <dsterba@suse.cz> - 2017-07-10 18:20 +0200
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2017-07-05 17:30 +0200 |
| Subject | [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options |
| Message-ID | <tZUpz-83i-15@gated-at.bofh.it> |
btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs
calls replace_mount_options(), but they then implement their own
->show_options() methods and don't touch s_options, rendering the saved
options unnecessary. I'm trying to eliminate s_options to make it easier
to implement a context-based mount where the mount options can be passed
individually over a file descriptor.
Remove the calls to save/replace_mount_options() call in these cases.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Chris Mason <clm@fb.com>
cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc: Steven Rostedt <rostedt@goodmis.org>
cc: linux-btrfs@vger.kernel.org
cc: reiserfs-devel@vger.kernel.org
---
fs/btrfs/super.c | 1 -
fs/debugfs/inode.c | 2 --
fs/reiserfs/super.c | 4 ----
fs/tracefs/inode.c | 2 --
4 files changed, 9 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 4f1cdd5058f1..8e9758b3eb23 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -1164,7 +1164,6 @@ static int btrfs_fill_super(struct super_block *sb,
goto fail_close;
}
- save_mount_options(sb, data);
cleancache_init_fs(sb);
sb->s_flags |= MS_ACTIVE;
return 0;
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
index e892ae7d89f8..0dc9e9c0e0f8 100644
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -203,8 +203,6 @@ static int debug_fill_super(struct super_block *sb, void *data, int silent)
struct debugfs_fs_info *fsi;
int err;
- save_mount_options(sb, data);
-
fsi = kzalloc(sizeof(struct debugfs_fs_info), GFP_KERNEL);
sb->s_fs_info = fsi;
if (!fsi) {
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 685f1e056998..306e4e9d172d 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -1599,8 +1599,6 @@ static int reiserfs_remount(struct super_block *s, int *mount_flags, char *arg)
}
out_ok_unlocked:
- if (new_opts)
- replace_mount_options(s, new_opts);
return 0;
out_err_unlock:
@@ -1916,8 +1914,6 @@ static int reiserfs_fill_super(struct super_block *s, void *data, int silent)
char *qf_names[REISERFS_MAXQUOTAS] = {};
unsigned int qfmt = 0;
- save_mount_options(s, data);
-
sbi = kzalloc(sizeof(struct reiserfs_sb_info), GFP_KERNEL);
if (!sbi)
return -ENOMEM;
diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 328e89c2cf83..bea8ad876bf9 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -270,8 +270,6 @@ static int trace_fill_super(struct super_block *sb, void *data, int silent)
struct tracefs_fs_info *fsi;
int err;
- save_mount_options(sb, data);
-
fsi = kzalloc(sizeof(struct tracefs_fs_info), GFP_KERNEL);
sb->s_fs_info = fsi;
if (!fsi) {
[toc] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2017-07-05 17:40 +0200 |
| Subject | Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options |
| Message-ID | <tZUzf-86u-7@gated-at.bofh.it> |
| In reply to | #1681585 |
Steven Rostedt <rostedt@goodmis.org> wrote: > As this is patch 1/14, is there any dependency on this working? That > is, it is safe to simply remove this caller from those locations? Or > are there dependencies on having any of the 2-14 patches added to make > it not cause issues? Patch 14 removes the then-unused helpers, but patches 1-13 otherwise are independent of each other and have no dependencies on earlier patches. David
[toc] | [prev] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2017-07-05 21:00 +0200 |
| Message-ID | <tZXGN-1Dt-3@gated-at.bofh.it> |
| In reply to | #1681603 |
On Wed, 05 Jul 2017 16:33:29 +0100 David Howells <dhowells@redhat.com> wrote: > Steven Rostedt <rostedt@goodmis.org> wrote: > > > As this is patch 1/14, is there any dependency on this working? That > > is, it is safe to simply remove this caller from those locations? Or > > are there dependencies on having any of the 2-14 patches added to make > > it not cause issues? > > Patch 14 removes the then-unused helpers, but patches 1-13 otherwise are > independent of each other and have no dependencies on earlier patches. > So basically it's an useless function call wrt tracefs. In that case... Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> -- Steve
[toc] | [prev] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2017-07-05 17:40 +0200 |
| Message-ID | <tZUzf-86u-9@gated-at.bofh.it> |
| In reply to | #1681585 |
On Wed, 05 Jul 2017 16:24:09 +0100 David Howells <dhowells@redhat.com> wrote: > btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs > calls replace_mount_options(), but they then implement their own > ->show_options() methods and don't touch s_options, rendering the saved > options unnecessary. I'm trying to eliminate s_options to make it easier > to implement a context-based mount where the mount options can be passed > individually over a file descriptor. > > Remove the calls to save/replace_mount_options() call in these cases. > As this is patch 1/14, is there any dependency on this working? That is, it is safe to simply remove this caller from those locations? Or are there dependencies on having any of the 2-14 patches added to make it not cause issues? -- Steve
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-07-05 21:00 +0200 |
| Message-ID | <tZXGN-1Dt-7@gated-at.bofh.it> |
| In reply to | #1681585 |
On Wed, Jul 05, 2017 at 04:24:09PM +0100, David Howells wrote: > btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs > calls replace_mount_options(), but they then implement their own > ->show_options() methods and don't touch s_options, rendering the saved > options unnecessary. I'm trying to eliminate s_options to make it easier > to implement a context-based mount where the mount options can be passed > individually over a file descriptor. > > Remove the calls to save/replace_mount_options() call in these cases. > > Signed-off-by: David Howells <dhowells@redhat.com> > cc: Chris Mason <clm@fb.com> > cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > cc: Steven Rostedt <rostedt@goodmis.org> > cc: linux-btrfs@vger.kernel.org > cc: reiserfs-devel@vger.kernel.org For debugfs: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[toc] | [prev] | [next] | [standalone]
| From | David Sterba <dsterba@suse.cz> |
|---|---|
| Date | 2017-07-10 18:20 +0200 |
| Message-ID | <u1JzH-7hc-7@gated-at.bofh.it> |
| In reply to | #1681585 |
On Wed, Jul 05, 2017 at 04:24:09PM +0100, David Howells wrote: > btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs > calls replace_mount_options(), but they then implement their own > ->show_options() methods and don't touch s_options, rendering the saved > options unnecessary. I'm trying to eliminate s_options to make it easier > to implement a context-based mount where the mount options can be passed > individually over a file descriptor. > > Remove the calls to save/replace_mount_options() call in these cases. > > Signed-off-by: David Howells <dhowells@redhat.com> > cc: Chris Mason <clm@fb.com> > cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > cc: Steven Rostedt <rostedt@goodmis.org> > cc: linux-btrfs@vger.kernel.org > cc: reiserfs-devel@vger.kernel.org > --- For > fs/btrfs/super.c | 1 - Acked-by: David Sterba <dsterba@suse.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web