Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681605

Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options

Show all headers | View raw

On Wed, 05 Jul 2017 16:24:09 +0100
David Howells <dhowells@redhat.com> wrote:

> btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs
> calls replace_mount_options(), but they then implement their own
> ->show_options() methods and don't touch s_options, rendering the saved  
> options unnecessary.  I'm trying to eliminate s_options to make it easier
> to implement a context-based mount where the mount options can be passed
> individually over a file descriptor.
> 
> Remove the calls to save/replace_mount_options() call in these cases.
> 

As this is patch 1/14, is there any dependency on this working? That
is, it is safe to simply remove this caller from those locations? Or
are there dependencies on having any of the 2-14 patches added to make
it not cause issues?

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/14] VFS: Don't use save/replace_mount_options if not  using generic_show_options David Howells <dhowells@redhat.com> - 2017-07-05 17:30 +0200
  Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options David Howells <dhowells@redhat.com> - 2017-07-05 17:40 +0200
    Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not  using generic_show_options Steven Rostedt <rostedt@goodmis.org> - 2017-07-05 21:00 +0200
  Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not  using generic_show_options Steven Rostedt <rostedt@goodmis.org> - 2017-07-05 17:40 +0200
  Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not  using generic_show_options Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-05 21:00 +0200
  Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not  using generic_show_options David Sterba <dsterba@suse.cz> - 2017-07-10 18:20 +0200

csiph-web