Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679750 > unrolled thread
| Started by | Lynn Lei <lynnl.wit@gmail.com> |
|---|---|
| First post | 2017-07-03 10:20 +0200 |
| Last post | 2017-07-03 10:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] staging: sm750fb: fixed a assignment typo Lynn Lei <lynnl.wit@gmail.com> - 2017-07-03 10:20 +0200
Re: [PATCH v2] staging: sm750fb: fixed a assignment typo Greg KH <gregkh@linuxfoundation.org> - 2017-07-03 10:40 +0200
| From | Lynn Lei <lynnl.wit@gmail.com> |
|---|---|
| Date | 2017-07-03 10:20 +0200 |
| Subject | [PATCH v2] staging: sm750fb: fixed a assignment typo |
| Message-ID | <tZ4Km-6Tf-19@gated-at.bofh.it> |
fixed a typo issue in get_mxclk_freq(). the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. which is not right, it should be PLL_CTRL_N_SHIFT. both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT defined in drivers/staging/sm750fb/ddk750_reg.h Signed-off-by: Lynn Lei <lynnl.wit@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 5e4bfb601cea..c51761221131 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -40,7 +40,7 @@ static unsigned int get_mxclk_freq(void) pll_reg = peek32(MXCLK_PLL_CTRL); M = (pll_reg & PLL_CTRL_M_MASK) >> PLL_CTRL_M_SHIFT; - N = (pll_reg & PLL_CTRL_N_MASK) >> PLL_CTRL_M_SHIFT; + N = (pll_reg & PLL_CTRL_N_MASK) >> PLL_CTRL_N_SHIFT; OD = (pll_reg & PLL_CTRL_OD_MASK) >> PLL_CTRL_OD_SHIFT; POD = (pll_reg & PLL_CTRL_POD_MASK) >> PLL_CTRL_POD_SHIFT; -- 2.13.2
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-07-03 10:40 +0200 |
| Message-ID | <tZ53I-70B-7@gated-at.bofh.it> |
| In reply to | #1679750 |
On Mon, Jul 03, 2017 at 04:13:15PM +0800, Lynn Lei wrote: > fixed a typo issue in get_mxclk_freq(). > > the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. > which is not right, it should be PLL_CTRL_N_SHIFT. > > both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT > defined in drivers/staging/sm750fb/ddk750_reg.h > > Signed-off-by: Lynn Lei <lynnl.wit@gmail.com> > --- > drivers/staging/sm750fb/ddk750_chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Always put what changed from the previous version here below the --- line, like the Documentation states to do. v3 please? thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web