Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1679760

Re: [PATCH v2] staging: sm750fb: fixed a assignment typo

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] staging: sm750fb: fixed a assignment typo
Date 2017-07-03 10:40 +0200
Message-ID <tZ53I-70B-7@gated-at.bofh.it> (permalink)
References <tZ4Km-6Tf-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jul 03, 2017 at 04:13:15PM +0800, Lynn Lei wrote:
> fixed a typo issue in get_mxclk_freq().
> 
> the original code using PLL_CTRL_M_SHIFT for shifting to set N flag.
> which is not right, it should be PLL_CTRL_N_SHIFT.
> 
> both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
>   defined in drivers/staging/sm750fb/ddk750_reg.h
> 
> Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Always put what changed from the previous version here below the ---
line, like the Documentation states to do.

v3 please?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH v2] staging: sm750fb: fixed a assignment typo Lynn Lei <lynnl.wit@gmail.com> - 2017-07-03 10:20 +0200
  Re: [PATCH v2] staging: sm750fb: fixed a assignment typo Greg KH <gregkh@linuxfoundation.org> - 2017-07-03 10:40 +0200

csiph-web