Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1678918 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-06-30 17:50 +0200 |
| Last post | 2017-07-03 09:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: typec: include linux/device.h in ucsi.h Arnd Bergmann <arnd@arndb.de> - 2017-06-30 17:50 +0200
Re: [PATCH] usb: typec: include linux/device.h in ucsi.h Guenter Roeck <linux@roeck-us.net> - 2017-06-30 18:00 +0200
Re: [PATCH] usb: typec: include linux/device.h in ucsi.h Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2017-07-03 09:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-06-30 17:50 +0200 |
| Subject | [PATCH] usb: typec: include linux/device.h in ucsi.h |
| Message-ID | <tY6lc-7hu-37@gated-at.bofh.it> |
The new driver causes a build failure in some configurations:
In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
This includes the required header file.
Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/typec/ucsi/ucsi.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
index 6b0d2f0918c6..8a88f45822e3 100644
--- a/drivers/usb/typec/ucsi/ucsi.h
+++ b/drivers/usb/typec/ucsi/ucsi.h
@@ -3,6 +3,7 @@
#define __DRIVER_USB_TYPEC_UCSI_H
#include <linux/bitops.h>
+#include <linux/device.h>
#include <linux/types.h>
/* -------------------------------------------------------------------------- */
--
2.9.0
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2017-06-30 18:00 +0200 |
| Message-ID | <tY6uS-7l1-19@gated-at.bofh.it> |
| In reply to | #1678918 |
On 06/30/2017 08:46 AM, Arnd Bergmann wrote:
> The new driver causes a build failure in some configurations:
>
> In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
> from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
> drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> This includes the required header file.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/ucsi/ucsi.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6b0d2f0918c6..8a88f45822e3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -3,6 +3,7 @@
> #define __DRIVER_USB_TYPEC_UCSI_H
>
> #include <linux/bitops.h>
> +#include <linux/device.h>
> #include <linux/types.h>
>
> /* -------------------------------------------------------------------------- */
>
[toc] | [prev] | [next] | [standalone]
| From | Heikki Krogerus <heikki.krogerus@linux.intel.com> |
|---|---|
| Date | 2017-07-03 09:00 +0200 |
| Message-ID | <tZ3uV-5SC-1@gated-at.bofh.it> |
| In reply to | #1678918 |
On Fri, Jun 30, 2017 at 05:46:16PM +0200, Arnd Bergmann wrote:
> The new driver causes a build failure in some configurations:
>
> In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0,
> from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2:
> drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> This includes the required header file.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/ucsi/ucsi.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6b0d2f0918c6..8a88f45822e3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -3,6 +3,7 @@
> #define __DRIVER_USB_TYPEC_UCSI_H
>
> #include <linux/bitops.h>
> +#include <linux/device.h>
> #include <linux/types.h>
>
> /* -------------------------------------------------------------------------- */
> --
> 2.9.0
--
heikki
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web