Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1670139 > unrolled thread

[PATCH v2 0/5] i2c: pca-platform: updates

Started byChris Packham <chris.packham@alliedtelesis.co.nz>
First post2017-06-20 03:20 +0200
Last post2017-06-28 14:10 +0200
Articles 15 on this page of 35 — 6 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/5] i2c: pca-platform: updates Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
    [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
      Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-22 10:30 +0200
        Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-22 23:30 +0200
          Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 10:20 +0200
          Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Rob Herring <robh@kernel.org> - 2017-06-23 23:50 +0200
    [PATCH v2 4/5] i2c: pca-platform: use device managed allocations Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
    [PATCH v2 3/5] i2c: pca-platform: use gpio_is_valid Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
    [PATCH v2 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:30 +0200
    [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
      Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
      Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
        Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:50 +0200
        Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:20 +0200
    [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
      Re: [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Rob Herring <robh+dt@kernel.org> - 2017-06-26 16:10 +0200
      Re: [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
    [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
      Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
      Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
        Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:30 +0200
          Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Wolfram Sang <wsa@the-dreams.de> - 2017-06-29 00:20 +0200
    [PATCH v3 0/5] i2c: pca-platform: updates Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
      [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
        Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
        Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
          Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:40 +0200
            Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 13:00 +0200
              Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:10 +0200
      [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
        Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
        Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
          Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:40 +0200
            Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 13:00 +0200
              Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead  of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 14:10 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1677185 — Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

FromChris Packham <Chris.Packham@alliedtelesis.co.nz>
Date2017-06-28 23:30 +0200
SubjectRe: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc
Message-ID<tXsH7-rB-3@gated-at.bofh.it>
In reply to#1676478
On 28/06/17 21:25, Andy Shevchenko wrote:
> On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
>> Make use of struct gpio_desc which allows us to specify the active state
>> of the reset pin.
> 
>> +               if (gpio_is_valid(platform_data->gpio)) {
> 
> No way, it should be provided by GPIO lookup table.
> 

Can do. The only platform that would be affected is 
arch/sh/boards/board-sh7785lcr.c and the fact that it sets gpio = 0 
makes me think that this might be an error.

>> +                       ret = devm_gpio_request_one(&pdev->dev,
>> +                                                   platform_data->gpio,
>> +                                                   GPIOF_ACTIVE_LOW,
>> +                                                   i2c->adap.name);
>> +                       if (ret == 0) {
>> +                               i2c->gpio = gpio_to_desc(platform_data->gpio);
> 
> This has to be devm_gpiod_get() instead.

I can just make the devm_gpiod_get_optional() call I add in 3/5 
unconditional.

> 
> Wolfram, I suggested to drop the series for now and wait for improvements.
> 

Wolframs call. I don't mind either way. I can send a v4 or send a new 
series on top of i2c.git#for-next.

[toc] | [prev] | [next] | [standalone]

#1677228 — Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc

FromWolfram Sang <wsa@the-dreams.de>
Date2017-06-29 00:20 +0200
SubjectRe: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc
Message-ID<tXttv-ZE-3@gated-at.bofh.it>
In reply to#1677185

[Multipart message — attachments visible in raw view] — view raw

> Wolframs call. I don't mind either way. I can send a v4 or send a new 
> series on top of i2c.git#for-next.

I think we can work incrementally on what I pushed out already.

Thanks!

[toc] | [prev] | [next] | [standalone]

#1674360 — [PATCH v3 0/5] i2c: pca-platform: updates

FromChris Packham <chris.packham@alliedtelesis.co.nz>
Date2017-06-26 02:50 +0200
Subject[PATCH v3 0/5] i2c: pca-platform: updates
Message-ID<tWqo1-3Ek-3@gated-at.bofh.it>
In reply to#1670139
We're using a PCA9564 on an embedded platform to provide an i2c
controller. This adds devicetree support and I've included some
cleanups for the driver while I was at it.

Chris Packham (5):
  dt-bindings: add bindings for i2c-pca-platform
  i2c: pca-platform: switch to struct gpio_desc
  i2c: pca-platform: add devicetree awareness
  i2c: pca-platform: use device managed allocations
  i2c: pca-platform: use dev_warn/dev_info instead of printk

 .../devicetree/bindings/i2c/i2c-pca-platform.txt   |  29 +++++
 drivers/i2c/busses/i2c-pca-platform.c              | 125 +++++++++------------
 2 files changed, 84 insertions(+), 70 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-pca-platform.txt

-- 
2.13.0

[toc] | [prev] | [next] | [standalone]

#1674362 — [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

FromChris Packham <chris.packham@alliedtelesis.co.nz>
Date2017-06-26 02:50 +0200
Subject[PATCH v3 4/5] i2c: pca-platform: use device managed allocations
Message-ID<tWqo2-3Ek-11@gated-at.bofh.it>
In reply to#1674360
Switch to using the devm_ APIs and remove the now unnecessary error
handling and most of the device removal code.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/i2c/busses/i2c-pca-platform.c | 53 +++++++----------------------------
 1 file changed, 10 insertions(+), 43 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index a6df6b8d2289..7db481cbf402 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -143,35 +143,23 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 	int ret = 0;
 	int irq;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	irq = platform_get_irq(pdev, 0);
 	/* If irq is 0, we do polling. */
 	if (irq < 0)
 		irq = 0;
 
-	if (res == NULL) {
-		ret = -ENODEV;
-		goto e_print;
-	}
+	i2c = devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL);
+	if (!i2c)
+		return -ENOMEM;
 
-	if (!request_mem_region(res->start, resource_size(res), res->name)) {
-		ret = -ENOMEM;
-		goto e_print;
-	}
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	i2c->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(i2c->reg_base))
+		return PTR_ERR(i2c->reg_base);
 
-	i2c = kzalloc(sizeof(struct i2c_pca_pf_data), GFP_KERNEL);
-	if (!i2c) {
-		ret = -ENOMEM;
-		goto e_alloc;
-	}
 
 	init_waitqueue_head(&i2c->wait);
 
-	i2c->reg_base = ioremap(res->start, resource_size(res));
-	if (!i2c->reg_base) {
-		ret = -ENOMEM;
-		goto e_remap;
-	}
 	i2c->io_base = res->start;
 	i2c->io_size = resource_size(res);
 	i2c->irq = irq;
@@ -236,15 +224,14 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 	}
 
 	if (irq) {
-		ret = request_irq(irq, i2c_pca_pf_handler,
+		ret = devm_request_irq(&pdev->dev, irq, i2c_pca_pf_handler,
 			IRQF_TRIGGER_FALLING, pdev->name, i2c);
 		if (ret)
-			goto e_reqirq;
+			return ret;
 	}
 
 	if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
-		ret = -ENODEV;
-		goto e_adapt;
+		return -ENODEV;
 	}
 
 	platform_set_drvdata(pdev, i2c);
@@ -252,19 +239,6 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 	printk(KERN_INFO "%s registered.\n", i2c->adap.name);
 
 	return 0;
-
-e_adapt:
-	if (irq)
-		free_irq(irq, i2c);
-e_reqirq:
-	iounmap(i2c->reg_base);
-e_remap:
-	kfree(i2c);
-e_alloc:
-	release_mem_region(res->start, resource_size(res));
-e_print:
-	printk(KERN_ERR "Registering PCA9564/PCA9665 FAILED! (%d)\n", ret);
-	return ret;
 }
 
 static int i2c_pca_pf_remove(struct platform_device *pdev)
@@ -273,13 +247,6 @@ static int i2c_pca_pf_remove(struct platform_device *pdev)
 
 	i2c_del_adapter(&i2c->adap);
 
-	if (i2c->irq)
-		free_irq(i2c->irq, i2c);
-
-	iounmap(i2c->reg_base);
-	release_mem_region(i2c->io_base, i2c->io_size);
-	kfree(i2c);
-
 	return 0;
 }
 
-- 
2.13.0

[toc] | [prev] | [next] | [standalone]

#1676129 — Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

FromWolfram Sang <wsa@the-dreams.de>
Date2017-06-27 22:00 +0200
SubjectRe: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations
Message-ID<tX4Ot-5bs-7@gated-at.bofh.it>
In reply to#1674362

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jun 26, 2017 at 12:44:33PM +1200, Chris Packham wrote:
> Switch to using the devm_ APIs and remove the now unnecessary error
> handling and most of the device removal code.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

And "reverted" the previous fix here:

-               if (IS_ERR(i2c->gpio)) {
-                       ret = PTR_ERR(i2c->gpio);
-                       goto e_reqirq;
-               }
+               if (IS_ERR(i2c->gpio))
+                       return PTR_ERR(i2c->gpio);

Applied to for-next, thanks!

[toc] | [prev] | [next] | [standalone]

#1676486 — Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-06-28 11:30 +0200
SubjectRe: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations
Message-ID<tXhsm-50j-33@gated-at.bofh.it>
In reply to#1674362
On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> Switch to using the devm_ APIs and remove the now unnecessary error
> handling and most of the device removal code.


>         if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
> -               ret = -ENODEV;
> -               goto e_adapt;
> +               return -ENODEV;

This is still shadows the actual error code.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1676491 — Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

FromWolfram Sang <wsa@the-dreams.de>
Date2017-06-28 11:40 +0200
SubjectRe: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations
Message-ID<tXhC2-53u-11@gated-at.bofh.it>
In reply to#1676486

[Multipart message — attachments visible in raw view] — view raw

> >         if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
> > -               ret = -ENODEV;
> > -               goto e_adapt;
> > +               return -ENODEV;
> 
> This is still shadows the actual error code.

Nice catch. But since it fixes a seperate issue, I'd prefer an
incremental change here.

[toc] | [prev] | [next] | [standalone]

#1676549 — Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-06-28 13:00 +0200
SubjectRe: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations
Message-ID<tXiRr-5KR-1@gated-at.bofh.it>
In reply to#1676491
On Wed, Jun 28, 2017 at 12:38 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> >         if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>> > -               ret = -ENODEV;
>> > -               goto e_adapt;
>> > +               return -ENODEV;
>>
>> This is still shadows the actual error code.
>
> Nice catch. But since it fixes a seperate issue, I'd prefer an
> incremental change here.

Agreed.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1677178 — Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

FromChris Packham <Chris.Packham@alliedtelesis.co.nz>
Date2017-06-28 23:10 +0200
SubjectRe: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations
Message-ID<tXsnM-2zA-29@gated-at.bofh.it>
In reply to#1676549
On 28/06/17 22:54, Andy Shevchenko wrote:
> On Wed, Jun 28, 2017 at 12:38 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>>>>          if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>>>> -               ret = -ENODEV;
>>>> -               goto e_adapt;
>>>> +               return -ENODEV;
>>>
>>> This is still shadows the actual error code.
>>
>> Nice catch. But since it fixes a seperate issue, I'd prefer an
>> incremental change here.
> 
> Agreed.
> 

OK I can send another patch for that.

[toc] | [prev] | [next] | [standalone]

#1674363 — [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

FromChris Packham <chris.packham@alliedtelesis.co.nz>
Date2017-06-26 02:50 +0200
Subject[PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk
Message-ID<tWqo2-3Ek-13@gated-at.bofh.it>
In reply to#1674360
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/i2c/busses/i2c-pca-platform.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index 7db481cbf402..395eca0cbb1f 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -107,8 +107,8 @@ static int i2c_pca_pf_waitforcompletion(void *pd)
 static void i2c_pca_pf_dummyreset(void *pd)
 {
 	struct i2c_pca_pf_data *i2c = pd;
-	printk(KERN_WARNING "%s: No reset-pin found. Chip may get stuck!\n",
-		i2c->adap.name);
+
+	dev_warn(&i2c->adap.dev, "No reset-pin found. Chip may get stuck!\n");
 }
 
 static void i2c_pca_pf_resetchip(void *pd)
@@ -236,7 +236,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, i2c);
 
-	printk(KERN_INFO "%s registered.\n", i2c->adap.name);
+	dev_info(&pdev->dev, "registered.\n");
 
 	return 0;
 }
-- 
2.13.0

[toc] | [prev] | [next] | [standalone]

#1676128 — Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

FromWolfram Sang <wsa@the-dreams.de>
Date2017-06-27 22:00 +0200
SubjectRe: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk
Message-ID<tX4Ot-5bs-5@gated-at.bofh.it>
In reply to#1674363

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jun 26, 2017 at 12:44:34PM +1200, Chris Packham wrote:
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Applied to for-next, thanks!

[toc] | [prev] | [next] | [standalone]

#1676485 — Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-06-28 11:30 +0200
SubjectRe: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk
Message-ID<tXhsm-50j-31@gated-at.bofh.it>
In reply to#1674363
On Mon, Jun 26, 2017 at 3:44 AM, Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:

On the first glance I have thought this is _the_ only patch that
doesn't make my eyes hurt.

Not a chance! Where is the commit message?

Code below though looks fine.

> @@ -107,8 +107,8 @@ static int i2c_pca_pf_waitforcompletion(void *pd)
>  static void i2c_pca_pf_dummyreset(void *pd)
>  {
>         struct i2c_pca_pf_data *i2c = pd;
> -       printk(KERN_WARNING "%s: No reset-pin found. Chip may get stuck!\n",
> -               i2c->adap.name);
> +
> +       dev_warn(&i2c->adap.dev, "No reset-pin found. Chip may get stuck!\n");
>  }
>
>  static void i2c_pca_pf_resetchip(void *pd)
> @@ -236,7 +236,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
>
>         platform_set_drvdata(pdev, i2c);
>
> -       printk(KERN_INFO "%s registered.\n", i2c->adap.name);
> +       dev_info(&pdev->dev, "registered.\n");
>
>         return 0;
>  }
> --
> 2.13.0
>



-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1676494 — Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

FromWolfram Sang <wsa@the-dreams.de>
Date2017-06-28 11:40 +0200
SubjectRe: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk
Message-ID<tXhC3-53u-35@gated-at.bofh.it>
In reply to#1676485

[Multipart message — attachments visible in raw view] — view raw

> Not a chance! Where is the commit message?

Don't you think $subject is clear enough?

[toc] | [prev] | [next] | [standalone]

#1676553 — Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2017-06-28 13:00 +0200
SubjectRe: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk
Message-ID<tXiRs-5KR-21@gated-at.bofh.it>
In reply to#1676494
On Wed, Jun 28, 2017 at 12:37 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> Not a chance! Where is the commit message?
>
> Don't you think $subject is clear enough?

I would add the comment at least on how the output is changed since
pr_*("%s:"..., i2c->adap.name,...)  to dev_*(&pdev->dev, ...)
replacement.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1676601 — Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk

FromWolfram Sang <wsa@the-dreams.de>
Date2017-06-28 14:10 +0200
SubjectRe: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk
Message-ID<tXjXc-6DX-19@gated-at.bofh.it>
In reply to#1676553

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jun 28, 2017 at 01:57:01PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 28, 2017 at 12:37 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> >
> >> Not a chance! Where is the commit message?
> >
> > Don't you think $subject is clear enough?
> 
> I would add the comment at least on how the output is changed since
> pr_*("%s:"..., i2c->adap.name,...)  to dev_*(&pdev->dev, ...)
> replacement.

Yes, that could have been done.

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web