Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677178
| From | Chris Packham <Chris.Packham@alliedtelesis.co.nz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations |
| Date | 2017-06-28 23:10 +0200 |
| Message-ID | <tXsnM-2zA-29@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <tWqo1-3Ek-3@gated-at.bofh.it> <tWqo2-3Ek-11@gated-at.bofh.it> <tXhsm-50j-33@gated-at.bofh.it> <tXhC2-53u-11@gated-at.bofh.it> <tXiRr-5KR-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 28/06/17 22:54, Andy Shevchenko wrote:
> On Wed, Jun 28, 2017 at 12:38 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>>
>>>> if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>>>> - ret = -ENODEV;
>>>> - goto e_adapt;
>>>> + return -ENODEV;
>>>
>>> This is still shadows the actual error code.
>>
>> Nice catch. But since it fixes a seperate issue, I'd prefer an
>> incremental change here.
>
> Agreed.
>
OK I can send another patch for that.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/5] i2c: pca-platform: updates Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
[PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-22 10:30 +0200
Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-22 23:30 +0200
Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-23 10:20 +0200
Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Rob Herring <robh@kernel.org> - 2017-06-23 23:50 +0200
[PATCH v2 4/5] i2c: pca-platform: use device managed allocations Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
[PATCH v2 3/5] i2c: pca-platform: use gpio_is_valid Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:20 +0200
[PATCH v2 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-20 03:30 +0200
[PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:50 +0200
Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:20 +0200
[PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
Re: [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Rob Herring <robh+dt@kernel.org> - 2017-06-26 16:10 +0200
Re: [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
[PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:30 +0200
Re: [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Wolfram Sang <wsa@the-dreams.de> - 2017-06-29 00:20 +0200
[PATCH v3 0/5] i2c: pca-platform: updates Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
[PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:40 +0200
Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 13:00 +0200
Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-06-28 23:10 +0200
[PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-06-26 02:50 +0200
Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 22:00 +0200
Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 11:30 +0200
Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 11:40 +0200
Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-06-28 13:00 +0200
Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Wolfram Sang <wsa@the-dreams.de> - 2017-06-28 14:10 +0200
csiph-web