Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1677818 > unrolled thread

Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled

Started byBen Hutchings <ben.hutchings@codethink.co.uk>
First post2017-06-29 16:40 +0200
Last post2017-06-29 16:40 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when  napi is disabled Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-06-29 16:40 +0200

#1677818 — Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled

FromBen Hutchings <ben.hutchings@codethink.co.uk>
Date2017-06-29 16:40 +0200
SubjectRe: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled
Message-ID<tXILT-ia-1@gated-at.bofh.it>
On Thu, 2017-06-15 at 19:52 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: hayeswang <hayeswang@realtek.com>
> 
> 
> [ Upstream commit de9bf29dd6e4a8a874cb92f8901aed50a9d0b1d3 ]
> 
> Stop the tx when the napi is disabled to prevent napi_schedule() is
> called.
[...]
> +	netif_stop_queue(netdev);
>  	napi_disable(&tp->napi);
[...]

netif_stop_queue() is not synchronous, so you probably need
netif_tx_disable() instead.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web