Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677818
| From | Ben Hutchings <ben.hutchings@codethink.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled |
| Date | 2017-06-29 16:40 +0200 |
| Message-ID | <tXILT-ia-1@gated-at.bofh.it> (permalink) |
| References | <tSHdL-5vC-7@gated-at.bofh.it> <tSHGP-5Wn-45@gated-at.bofh.it> |
| Organization | Codethink Ltd. |
On Thu, 2017-06-15 at 19:52 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: hayeswang <hayeswang@realtek.com> > > > [ Upstream commit de9bf29dd6e4a8a874cb92f8901aed50a9d0b1d3 ] > > Stop the tx when the napi is disabled to prevent napi_schedule() is > called. [...] > + netif_stop_queue(netdev); > napi_disable(&tp->napi); [...] netif_stop_queue() is not synchronous, so you probably need netif_tx_disable() instead. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when napi is disabled Ben Hutchings <ben.hutchings@codethink.co.uk> - 2017-06-29 16:40 +0200
csiph-web