Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676489 > unrolled thread

[PATCH 0/2] staging: ccree: Fix coding style and remove warnings

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] staging: ccree: Fix coding style and remove warnings karthik@techveda.org - 2017-06-28 11:40 +0200
    Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-28 11:50 +0200
      Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings karthik <karthik@techveda.org> - 2017-06-29 12:50 +0200
        Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 16:20 +0200
          [PATCH v2] staging: ccree: Use __func__ instead of function name karthik@techveda.org - 2017-06-29 19:10 +0200

#1676489 — [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

From: Karthik Tummala <karthik@techveda.org>

This patch series fixes coding style and removes the following
checkpatch.pl warnings:

Prefer using '"%s...", __func__' to using the function's name,
in a string.

Braces {} are not necessary for single statement blocks.

Rebased on top of next-20170627.
Patches were tested and built on next-20170627

Karthik Tummala (2):
  staging: ccree: Use __func__ instead of function name
  staging: ccree: Remove braces {} for single statement blocks

 drivers/staging/ccree/ssi_aead.c | 48 ++++++++++++++++------------------------
 1 file changed, 19 insertions(+), 29 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]

#1676499

Thank you Karthik,

On Wed, Jun 28, 2017 at 12:37 PM,  <karthik@techveda.org> wrote:
> From: Karthik Tummala <karthik@techveda.org>
>
> This patch series fixes coding style and removes the following
> checkpatch.pl warnings:
>
> Prefer using '"%s...", __func__' to using the function's name,
> in a string.

This one is good.
>
> Braces {} are not necessary for single statement blocks.

I have already sent a patch addressing this and some other things
yesterday/

>
> Rebased on top of next-20170627.
> Patches were tested and built on next-20170627

Can you please check patch 1 still applies after yesterdays patch series?

>
> Karthik Tummala (2):
>   staging: ccree: Use __func__ instead of function name
>   staging: ccree: Remove braces {} for single statement blocks
>
>  drivers/staging/ccree/ssi_aead.c | 48 ++++++++++++++++------------------------
>  1 file changed, 19 insertions(+), 29 deletions(-)
>
> --
> 1.9.1
>

Thanks,
Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

[toc] | [prev] | [next] | [standalone]

#1677598

On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote:
> Thank you Karthik,
> 
> On Wed, Jun 28, 2017 at 12:37 PM,  <karthik@techveda.org> wrote:
>> From: Karthik Tummala <karthik@techveda.org>
>>
>> This patch series fixes coding style and removes the following
>> checkpatch.pl warnings:
>>
>> Prefer using '"%s...", __func__' to using the function's name,
>> in a string.
> 
> This one is good.
>>
>> Braces {} are not necessary for single statement blocks.
> 
> I have already sent a patch addressing this and some other things
> yesterday/
> 
>>
>> Rebased on top of next-20170627.
>> Patches were tested and built on next-20170627
> 
> Can you please check patch 1 still applies after yesterdays patch series?
Hi, I have applied your patch series and then tried to apply patch 1 and 
it failed. Should I wait until the patch series gets accepted and then 
continue my work on the new linux-next release ? or is there any other 
option ?
> 
>>
>> Karthik Tummala (2):
>>    staging: ccree: Use __func__ instead of function name
>>    staging: ccree: Remove braces {} for single statement blocks
>>
>>   drivers/staging/ccree/ssi_aead.c | 48 ++++++++++++++++------------------------
>>   1 file changed, 19 insertions(+), 29 deletions(-)
>>
>> --
>> 1.9.1
>>
> 
> Thanks,
> Gilad
> 
Thanks
karthik

[toc] | [prev] | [next] | [standalone]

#1677791

On Thu, Jun 29, 2017 at 04:13:38PM +0530, karthik wrote:
> On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote:
> > Thank you Karthik,
> > 
> > On Wed, Jun 28, 2017 at 12:37 PM,  <karthik@techveda.org> wrote:
> > > From: Karthik Tummala <karthik@techveda.org>
> > > 
> > > This patch series fixes coding style and removes the following
> > > checkpatch.pl warnings:
> > > 
> > > Prefer using '"%s...", __func__' to using the function's name,
> > > in a string.
> > 
> > This one is good.
> > > 
> > > Braces {} are not necessary for single statement blocks.
> > 
> > I have already sent a patch addressing this and some other things
> > yesterday/
> > 
> > > 
> > > Rebased on top of next-20170627.
> > > Patches were tested and built on next-20170627
> > 
> > Can you please check patch 1 still applies after yesterdays patch series?
> Hi, I have applied your patch series and then tried to apply patch 1 and it
> failed. Should I wait until the patch series gets accepted and then continue
> my work on the new linux-next release ? or is there any other option ?

You need to rebased on top of these changes.  All of them are now in
staging-testing, soon to move to staging-next in a day or so.  Rebase on
there and resend.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1677961 — [PATCH v2] staging: ccree: Use __func__ instead of function name

From: Karthik Tummala <karthik@techveda.org>

Fixed following checkpatch.pl warning:
	WARNING: Prefer using '"%s...", __func__' to using
the function's name, in a string

It is prefered to use '%s & __func__' instead of function
name for logging.

Signed-off-by: Karthik Tummala <karthik@techveda.org>
---
Changes for v2:
v1 was a patch series, which consisted of two patches in which
second one was already submitted by Gilad Ben-Yossef, so dropped
that one.

Patch generated on staging-testing as suggested by Greg-K H.
---
 drivers/staging/ccree/ssi_aead.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 1fc0b05..1168161 100644
--- a/drivers/staging/ccree/ssi_aead.c
+++ b/drivers/staging/ccree/ssi_aead.c
@@ -1886,7 +1886,7 @@ static int config_gcm_context(struct aead_request *req)
 				(req->cryptlen - ctx->authsize);
 	__be32 counter = cpu_to_be32(2);
 
-	SSI_LOG_DEBUG("config_gcm_context() cryptlen = %d, req->assoclen = %d ctx->authsize = %d\n", cryptlen, req->assoclen, ctx->authsize);
+	SSI_LOG_DEBUG("%s() cryptlen = %d, req->assoclen = %d ctx->authsize = %d\n", __func__, cryptlen, req->assoclen, ctx->authsize);
 
 	memset(req_ctx->hkey, 0, AES_BLOCK_SIZE);
 
@@ -2198,7 +2198,7 @@ static int ssi_rfc4106_gcm_setkey(struct crypto_aead *tfm, const u8 *key, unsign
 	struct ssi_aead_ctx *ctx = crypto_aead_ctx(tfm);
 	int rc = 0;
 
-	SSI_LOG_DEBUG("ssi_rfc4106_gcm_setkey()  keylen %d, key %p\n", keylen, key);
+	SSI_LOG_DEBUG("%s()  keylen %d, key %p\n", __func__, keylen, key);
 
 	if (keylen < 4)
 		return -EINVAL;
@@ -2216,7 +2216,7 @@ static int ssi_rfc4543_gcm_setkey(struct crypto_aead *tfm, const u8 *key, unsign
 	struct ssi_aead_ctx *ctx = crypto_aead_ctx(tfm);
 	int rc = 0;
 
-	SSI_LOG_DEBUG("ssi_rfc4543_gcm_setkey()  keylen %d, key %p\n", keylen, key);
+	SSI_LOG_DEBUG("%s()  keylen %d, key %p\n", __func__, keylen, key);
 
 	if (keylen < 4)
 		return -EINVAL;
-- 
1.9.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web