Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677598

Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

Show all headers | View raw

On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote:
> Thank you Karthik,
> 
> On Wed, Jun 28, 2017 at 12:37 PM,  <karthik@techveda.org> wrote:
>> From: Karthik Tummala <karthik@techveda.org>
>>
>> This patch series fixes coding style and removes the following
>> checkpatch.pl warnings:
>>
>> Prefer using '"%s...", __func__' to using the function's name,
>> in a string.
> 
> This one is good.
>>
>> Braces {} are not necessary for single statement blocks.
> 
> I have already sent a patch addressing this and some other things
> yesterday/
> 
>>
>> Rebased on top of next-20170627.
>> Patches were tested and built on next-20170627
> 
> Can you please check patch 1 still applies after yesterdays patch series?
Hi, I have applied your patch series and then tried to apply patch 1 and 
it failed. Should I wait until the patch series gets accepted and then 
continue my work on the new linux-next release ? or is there any other 
option ?
> 
>>
>> Karthik Tummala (2):
>>    staging: ccree: Use __func__ instead of function name
>>    staging: ccree: Remove braces {} for single statement blocks
>>
>>   drivers/staging/ccree/ssi_aead.c | 48 ++++++++++++++++------------------------
>>   1 file changed, 19 insertions(+), 29 deletions(-)
>>
>> --
>> 1.9.1
>>
> 
> Thanks,
> Gilad
> 
Thanks
karthik

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] staging: ccree: Fix coding style and remove warnings karthik@techveda.org - 2017-06-28 11:40 +0200
  Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-28 11:50 +0200
    Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings karthik <karthik@techveda.org> - 2017-06-29 12:50 +0200
      Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-29 16:20 +0200
        [PATCH v2] staging: ccree: Use __func__ instead of function name karthik@techveda.org - 2017-06-29 19:10 +0200

csiph-web