Groups > linux.kernel > #1674918 > unrolled thread

[PATCH 0/3] Altera Quadspi Controller Version 2

Started by	matthew.gerlach@linux.intel.com
First post	2017-06-26 18:20 +0200
Last post	2017-06-27 13:00 +0200
Articles	2 on this page of 22 — 4 participants

Back to article view | Back to linux.kernel

  [PATCH 0/3] Altera Quadspi Controller Version 2 matthew.gerlach@linux.intel.com - 2017-06-26 18:20 +0200
    [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller Version 2 matthew.gerlach@linux.intel.com - 2017-06-26 18:20 +0200
      Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 12:30 +0200
        Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 16:40 +0200
          Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 17:20 +0200
            Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 18:00 +0200
              Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 18:30 +0200
                Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 19:20 +0200
                  Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 20:00 +0200
                    Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-27 21:40 +0200
                      Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 22:00 +0200
              Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Rob Herring <robh@kernel.org> - 2017-06-29 01:10 +0200
                Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-29 11:50 +0200
                  Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 matthew.gerlach@linux.intel.com - 2017-06-29 17:10 +0200
                    Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Marek Vasut <marek.vasut@gmail.com> - 2017-06-29 17:40 +0200
      Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller  Version 2 Rob Herring <robh@kernel.org> - 2017-06-29 01:20 +0200
    [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver matthew.gerlach@linux.intel.com - 2017-06-26 18:20 +0200
      Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 12:30 +0200
        Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver matthew.gerlach@linux.intel.com - 2017-06-27 17:40 +0200
          Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver Marek Vasut <marek.vasut@gmail.com> - 2017-06-27 18:30 +0200
            Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver matthew.gerlach@linux.intel.com - 2017-06-27 19:40 +0200
      Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2  Platform driver kbuild test robot <lkp@intel.com> - 2017-06-27 13:00 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1676031 — Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver

From	matthew.gerlach@linux.intel.com
Date	2017-06-27 19:40 +0200
Subject	Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver
Message-ID	<tX2D1-3Ko-35@gated-at.bofh.it>
In reply to	#1675974


On Tue, 27 Jun 2017, Marek Vasut wrote:

> On 06/27/2017 05:15 PM, matthew.gerlach@linux.intel.com wrote:
>>
>>
>> On Tue, 27 Jun 2017, Marek Vasut wrote:
>>
>>> On 06/26/2017 06:13 PM, matthew.gerlach@linux.intel.com wrote:
>>>> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>>
>>> Just wrap it into the Altera QSPI driver , no need for separate platform
>>> driver IMO.
>>
>> Hi Marek,
>>
>> I answered this question when you asked why the header file was
>> necessary, but I think further discussion could be helpful, since this
>> problem is becoming more prevelent.  The Altera Quadspi component is a
>> soft IP in a
>> FPGA, and the processor using the component may or may not have device
>> tree support compiled into the Linux kernel.  Since device tree support
>> may or may not be available, the device tree specific code must be
>> separated
>> from the core driver code.
>
> I see, that's fine, although there is no PCIe or other support in this
> submission. Is that planned ?

You probably would not see a PCIe driver for a card with a FPGA that would 
only have the Altera Quadspi component on it.  Usually a FPGA has several 
components, each requiring their own driver which are considered 
sub-drivers of the PCIe driver.  I will be adding Altera Quadspi support 
to the Intel-FPGA PCIe driver that is currently under review.  We have 
also seen people use the Altera Quadspi with a NIOS-II soft processor, and 
I expect someone would want to use the component with ARM SOCFPGAs.

Matthew Gerlach

>
>> One can certainly make the case, that device tree support could/should
>> be available everywhere, but the current reality is most x86 Linux
>> kernel configurations do not include device tree support.
>>
>> For the record, I believe device trees, and more specifically device
>> tree overlays, are the best way for Linux to use FPGAs, but I have to
>> deal with the current realities.
>>
>> Thanks again for all the great feedback.
>>
>> Matthew Gerlach
>
> [...]
>
> -- 
> Best regards,
> Marek Vasut
>

[toc] | [prev] | [next] | [standalone]

#1675545 — Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver

From	kbuild test robot <lkp@intel.com>
Date	2017-06-27 13:00 +0200
Subject	Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver
Message-ID	<tWWnU-7LB-7@gated-at.bofh.it>
In reply to	#1674921

[Multipart message — attachments visible in raw view] — view raw

Hi Matthew,

[auto build test ERROR on spi-nor/next]
[also build test ERROR on next-20170627]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/matthew-gerlach-linux-intel-com/Altera-Quadspi-Controller-Version-2/20170627-120604
base:   git://github.com/spi-nor/linux next
config: um-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um 

All errors (new ones prefixed by >>):

   arch/um/drivers/built-in.o: In function `vde_open_real':
   (.text+0xc9f1): warning: Using 'getgrnam' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
   arch/um/drivers/built-in.o: In function `vde_open_real':
   (.text+0xc83c): warning: Using 'getpwuid' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
   arch/um/drivers/built-in.o: In function `vde_open_real':
   (.text+0xcb55): warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
   arch/um/drivers/built-in.o: In function `pcap_nametoaddr':
   (.text+0x1d5e5): warning: Using 'gethostbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
   arch/um/drivers/built-in.o: In function `pcap_nametonetaddr':
   (.text+0x1d685): warning: Using 'getnetbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
   arch/um/drivers/built-in.o: In function `pcap_nametoproto':
   (.text+0x1d8a5): warning: Using 'getprotobyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
   arch/um/drivers/built-in.o: In function `pcap_nametoport':
   (.text+0x1d6d7): warning: Using 'getservbyname' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
   drivers/built-in.o: In function `altera_quadspi_probe':
>> drivers/mtd/spi-nor/altera-quadspi-platform.c:44: undefined reference to `devm_ioremap_resource'
   drivers/mtd/spi-nor/altera-quadspi-platform.c:51: undefined reference to `devm_ioremap_resource'
   drivers/mtd/spi-nor/altera-quadspi-platform.c:60: undefined reference to `devm_ioremap_resource'
   drivers/built-in.o: In function `img_ascii_lcd_probe':
   drivers/auxdisplay/img-ascii-lcd.c:386: undefined reference to `devm_ioremap_resource'
   collect2: error: ld returned 1 exit status

vim +44 drivers/mtd/spi-nor/altera-quadspi-platform.c

    38		if (!np) {
    39			dev_err(dev, "no device found\n");
    40			return -ENODEV;
    41		}
    42	
    43		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "avl_csr");
  > 44		csr_base = devm_ioremap_resource(dev, res);
    45		if (IS_ERR(csr_base)) {
    46			dev_err(dev, "%s: ERROR: failed to map csr base\n", __func__);
    47			return PTR_ERR(csr_base);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

csiph-web

[PATCH 0/3] Altera Quadspi Controller Version 2

Contents

#1676031 — Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver

#1675545 — Re: [PATCH 3/3] mtd: spi-nor: Altera Quadspi Flash Controller v2 Platform driver