Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1675383 > unrolled thread

[PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga <rjdurga@gmail.com> - 2017-06-27 09:50 +0200
    Re: [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal  permission representation Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 16:30 +0200

#1675383 — [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.

Signed-off-by: Jaya Durga <jayad@cdac.in>
---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
  */
 static int wifi_test;
 
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
 module_param(wifi_test, int, 0644);
 module_param(initmac, charp, 0644);
 module_param(video_mode, int, 0644);
-- 
1.9.1

[toc] | [next] | [standalone]

#1677816 — Re: [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation

On Tue, Jun 27, 2017 at 01:06:00PM +0530, Jaya Durga wrote:
> Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> Consider using octal permissions '0644'.
> 
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
>  drivers/staging/rtl8712/os_intfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I have a bizarre series of oddly numbered patches from you, and no where
is a whole, correctly numbered, set of patches that I can sort correctly
and apply to my tree knowing that I did not miss any.

So I've now dropped all of your patches you have sent to me from my
queue.  Please redo them all and resend them properly numbered in a
manner that makes it _obvious_ what ones I should review and what order
they should be applied in.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web