[PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation

From	Jaya Durga <rjdurga@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation
Date	2017-06-27 09:50 +0200
Message-ID	<tWTq2-5LM-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
Consider using octal permissions '0644'.

Signed-off-by: Jaya Durga <jayad@cdac.in>
---
 drivers/staging/rtl8712/os_intfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
index 8836b31..e698f6e 100644
--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -93,7 +93,7 @@
  */
 static int wifi_test;
 
-module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR);
+module_param_string(ifname, ifname, sizeof(ifname), 0644);
 module_param(wifi_test, int, 0644);
 module_param(initmac, charp, 0644);
 module_param(video_mode, int, 0644);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation Jaya Durga <rjdurga@gmail.com> - 2017-06-27 09:50 +0200
  Re: [PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal  permission representation Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 16:30 +0200

csiph-web