Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1674885 > unrolled thread
| Started by | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| First post | 2017-06-26 17:50 +0200 |
| Last post | 2017-06-26 18:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] xfs: fix semicolon.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-06-26 17:50 +0200
Re: [PATCH] xfs: fix semicolon.cocci warnings "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-06-26 18:00 +0200
Re: [PATCH] xfs: fix semicolon.cocci warnings Brian Foster <bfoster@redhat.com> - 2017-06-26 18:00 +0200
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2017-06-26 17:50 +0200 |
| Subject | [PATCH] xfs: fix semicolon.cocci warnings |
| Message-ID | <tWEqZ-4aL-3@gated-at.bofh.it> |
fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
CC: Brian Foster <bfoster@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
xfs_log.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -2089,7 +2089,7 @@ xlog_print_trans(
xfs_warn(mp, " type = 0x%x", vec->i_type);
xfs_warn(mp, " len = %d", vec->i_len);
xfs_warn(mp, " first %d bytes of iovec[%d]:", dumplen, i);
- xfs_hex_dump(vec->i_addr, dumplen);;
+ xfs_hex_dump(vec->i_addr, dumplen);
vec++;
}
[toc] | [next] | [standalone]
| From | "Darrick J. Wong" <darrick.wong@oracle.com> |
|---|---|
| Date | 2017-06-26 18:00 +0200 |
| Message-ID | <tWEAH-4e5-37@gated-at.bofh.it> |
| In reply to | #1674885 |
On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <bfoster@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Looks good, will test...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> xfs_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
> xfs_warn(mp, " type = 0x%x", vec->i_type);
> xfs_warn(mp, " len = %d", vec->i_len);
> xfs_warn(mp, " first %d bytes of iovec[%d]:", dumplen, i);
> - xfs_hex_dump(vec->i_addr, dumplen);;
> + xfs_hex_dump(vec->i_addr, dumplen);
>
> vec++;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Brian Foster <bfoster@redhat.com> |
|---|---|
| Date | 2017-06-26 18:00 +0200 |
| Message-ID | <tWEAH-4e5-39@gated-at.bofh.it> |
| In reply to | #1674885 |
On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <bfoster@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> xfs_log.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
> xfs_warn(mp, " type = 0x%x", vec->i_type);
> xfs_warn(mp, " len = %d", vec->i_len);
> xfs_warn(mp, " first %d bytes of iovec[%d]:", dumplen, i);
> - xfs_hex_dump(vec->i_addr, dumplen);;
> + xfs_hex_dump(vec->i_addr, dumplen);
>
> vec++;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web