Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1674903

Re: [PATCH] xfs: fix semicolon.cocci warnings

From "Darrick J. Wong" <darrick.wong@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] xfs: fix semicolon.cocci warnings
Date 2017-06-26 18:00 +0200
Message-ID <tWEAH-4e5-37@gated-at.bofh.it> (permalink)
References <tWEqZ-4aL-5@gated-at.bofh.it> <tWEqZ-4aL-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <bfoster@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Looks good, will test...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
>  xfs_log.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
>  			xfs_warn(mp, "    type	= 0x%x", vec->i_type);
>  			xfs_warn(mp, "    len	= %d", vec->i_len);
>  			xfs_warn(mp, "    first %d bytes of iovec[%d]:", dumplen, i);
> -			xfs_hex_dump(vec->i_addr, dumplen);;
> +			xfs_hex_dump(vec->i_addr, dumplen);
>  
>  			vec++;
>  		}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] xfs: fix semicolon.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-06-26 17:50 +0200
  Re: [PATCH] xfs: fix semicolon.cocci warnings "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-06-26 18:00 +0200
  Re: [PATCH] xfs: fix semicolon.cocci warnings Brian Foster <bfoster@redhat.com> - 2017-06-26 18:00 +0200

csiph-web